Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Add opt-in strict resolution of explicit `main` labels in `py_binary` and `py_test`

Aperta
  • Qualcosa non va?
#4,311 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
build-system

Direzione di ricerca

Read python/private/py_executable.bzl, especially determine_main in the version linked by the issue, and trace how py_binary and py_test pass main and srcs into entrypoint selection. Implementing this needs analysis-time artifact comparison, validation, and compatibility with generated outputs and aliases. Done means strict mode is opt-in, rejects mismatched artifacts with a clear diagnostic, preserves default behavior, and has coverage for the listed cases.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Relevant Rules

py_binary and py_test.

Description

The main attribute is label-valued, but entrypoint selection uses only ctx.attr.main.label.name to suffix-match files in srcs. Consequently, the explicit label does not necessarily identify the file selected as the entrypoint.

For example, suppose shared/entry.py exists and is exported by //shared, while app/entry.py does not exist:

# app/BUILD.bazel
load("@rules_python//python:defs.bzl", "py_binary")

py_binary(
    name = "app",
    srcs = ["//shared:entry.py"],
    main = "entry.py",
)

Bazel resolves main to //app:entry.py, but the rule selects //shared:entry.py through filename matching. The query graph can nevertheless contain a source-file target for the nonexistent //app:entry.py. Tools that consume this graph and inspect source files, such as bazel-diff, can then report missing-file warnings even though the actual entrypoint is correctly supplied through srcs.

There is also an ambiguity case:

py_binary(
    name = "app",
    srcs = [
        "//foo:entry.py",
        "//bar:entry.py",
    ],
    main = "//foo:entry.py",
)

Filename matching finds two candidates even though the explicit label identifies one file unambiguously.

In 2.4.3, the latest stable release, determine_main retains this filename-matching behavior. I recognize that it is intentional; this request is for an optional stricter contract, not an incompatible change to the default.

Describe the solution you'd like

Add an opt-in strict mode, for example a strict_main attribute defaulting to False. The specific API is open to discussion; enabling it through project-owned wrappers would allow gradual adoption.

When strict mode is enabled and main is explicitly provided:

  • Resolve the full label to its file artifact and use that artifact as the entrypoint.
  • Require that artifact to be among the files supplied by srcs.
  • Fail during analysis with a clear diagnostic if the requirement is not satisfied, rather than selecting a different file with a matching name.
  • Compare resolved artifacts rather than label strings, preserving support for aliases, single-file filegroups, and generated sources.
  • Preserve applicable entrypoint file-type validation.

Validation should compare the resolved main and srcs artifacts during analysis, including declared generated outputs. Bazel's normal build-time input and output checks should remain responsible for enforcing file availability. For example, a generated entrypoint is valid when both attributes resolve to the same declared output artifact; its generating action need not have run yet.

When main is omitted, retain the existing default-entrypoint inference. When strict mode is disabled, preserve existing behavior.

This would let projects enforce that explicit entrypoint labels accurately describe their dependencies without requiring an immediate migration for all users.

Describe alternatives you've considered

Correct individual declarations. Using main = "//shared:entry.py" fixes the first example's misleading graph entry. This is a useful immediate workaround, but the rule still accepts future mismatches, and fully qualified labels do not resolve the second example's filename ambiguity.

Project-local linting or analysis checks. These could enforce the policy locally, but would require separate tooling to validate the relationship between the resolved main and srcs artifacts. Enforcing the contract in the executable rule would provide a direct diagnostic where the entrypoint is selected.

Make exact label resolution the default immediately. This would be a breaking change for configurations that rely on the documented filename-matching behavior. An opt-in mode provides a compatibility-preserving adoption path.

Lingua principale
Starlark
Stelle
688
Fork
730
Merge medio
16h 50m
PR unite (30g)
136

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di bazel-contrib/rules_python

Tutte le issue di bazel-contrib/rules_python

Issue simili

Altre issue su Build System

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.