Feature request: right-to-left (RTL) support for Arabic documents
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- react, tailwindcss, typescript
- Ambito
- accessibility, frontend, internationalization
Direzione di ricerca
Start in packages/ui/components/BlockRenderer.tsx, which the request names as the place to set a per-block dir; the same treatment is needed in BlockquoteBlock.tsx and TableBlock.tsx. Read the block prop shape there to see where block.content is available, then implement the RTL-vs-Latin counting rule from the issue and swap physical classes for logical ones (marginInlineStart, border-s-2 ps-4, text-start). Done means Arabic lists, blockquotes and tables flip in plan review while English output is byte-for-byte unchanged; there is no test named in the payload, so verify in the annotate and plan-review views.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
Plans and documents written in Arabic (and other RTL languages) render left-to-right in annotate and plan review (plannotator 0.28.35, Windows, Claude Code):
- Arabic paragraphs and headings are left-aligned, and their punctuation jumps to the wrong end of the line.
- Bullets and numbers sit on the left of Arabic list items, and nested items indent from the left.
- The blockquote rule is on the left side.
- Table columns run left-to-right, and headers are forced left (
text-left). - The table of contents in the left sidebar has the same problems.
- Inline code inside an Arabic sentence (for example
Use `POST /ingest` herewritten in Arabic) splits the surrounding punctuation.
Agent output in Arabic is common now. The plans we review are mostly Arabic with English identifiers and code mixed in, so this affects every review.
Why dir="auto" is not enough
dir="auto" picks the direction from the first strong character. In mixed documents many Arabic lines start with an English identifier or code, for example a list item that begins with `POST /ingest` and continues in Arabic. Those lines would wrongly come out LTR. Short English-only headings inside an Arabic document (for example "Jev" or "WebSocket") also read better when they follow the document's direction.
Proposed change
-
A direction per block. For each block, take
block.content, drop the inline code spans, and compare the count of RTL letters with Latin letters:- The block is
rtlwhen RTL letters are at least half the Latin count. - The block is
ltrwhen it has only Latin text and at least about 30 letters. - Otherwise it follows the document's majority direction.
Set the result as a
dirattribute on the block root inpackages/ui/components/BlockRenderer.tsx(headings, paragraphs, list items),BlockquoteBlock.tsxandTableBlock.tsx. Then lists, tables and alignment follow from the browser's own bidi handling. - The block is
-
Logical properties instead of physical ones (Tailwind 4 supports them):
- list indent
style={{ marginLeft }}becomesmarginInlineStart; - blockquote
border-l-2 pl-4becomesborder-s-2 ps-4; - table headers
text-leftbecometext-start.
- list indent
-
Code stays LTR. Code blocks get
dir="ltr", and inlinecodegetsunicode-bidi: isolateso punctuation around it stays in place. -
Comments. The comment textarea gets
dir="auto", and the TOC entries use the same direction as their heading.
No text changes, so annotation offsets and quotes are unaffected. It also adds no setting: English documents keep rendering exactly as they do today.
Optional: a textDirection: "auto" | "ltr" | "rtl" setting for people who want to force one.
Workaround in the meantime
I'm using a small userscript that applies the same idea from outside: it sets dir per [data-block-id] and adds a few CSS overrides. It works, but it relies on internal class names and inline styles, so it breaks whenever the markup changes. A built-in fix would be much more robust.
I'm happy to open a PR along these lines if this direction works for you.
- Lingua principale
- TypeScript
- Stelle
- 8.7k
- Fork
- 649
- Merge medio
- 11h 48m
- PR unite (30g)
- 552
Preparare l'ambiente
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di backnotprop/plannotator
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 67/100
backnotprop/plannotator#2317 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
backnotprop/plannotator#2306 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
backnotprop/plannotator#2290 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
backnotprop/plannotator#2243 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Annotate documentation omits per-file version history and privacy controlsForse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
backnotprop/plannotator#1086 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di backnotprop/plannotator
Issue simili
-
Shell: serve the home app's Cookie Policy on a hard reloadForse già presa @2001anshkaushik l’ha presa oggi. Apertafeature module:ai
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
rocketride-org/rocketride-server#2899 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
wazuh/wazuh-dashboard-plugins#9551 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
gofish-graphics/gofish-graphics#1252 ·
I maintainer di solito rispondono entro 1 giorno
-
optimization P3 size:XS
Difficoltà 1/5 1-3 ore Idoneità per principianti 88/100
josephfung/curia#2366 ·
I maintainer di solito rispondono entro 1 giorno
-
stranded-follow-up sweep trusts any issue whose body carries the marker as the tracking issueApertatype:bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
nightgauge/nightgauge#2688 ·
I maintainer di solito rispondono entro 1 giorno