Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Event stream decoder drops the final event when reading it reaches EOF

Aperta
  • Qualcosa non va?
#3,374 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@lazerg ci sta già lavorando.

Dal 14/10/2026.

  • #3375 di @lazerg — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
aws, php
Ambito
api, backend

Direzione di ricerca

Start with valid() in the NonSeekableStreamDecodingEventStreamIterator class, which currently checks the stream's EOF state after the event is parsed. Run the reproduction in the issue against a BufferStream holding one event frame; it should print int(1) once the fix is in. Done means the final event is yielded even when the read hits EOF, and the existing decoder tests still pass. A test using BufferStream rather than php://temp would cover the regression.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe the bug

NonSeekableStreamDecodingEventStreamIterator drops the final event when reading it also reaches the end of the stream. If the stream contains just one event, nothing is returned.

valid() checks the stream’s EOF state after the event has already been parsed, so it can return false even though there’s a complete event ready to yield.

Expected Behavior

I think the decoder should still yield the last complete event, even if reading it reached the end of the stream.

Current Behavior

The example below prints int(0) instead of int(1). No exception is thrown.

Reproduction Steps

This example doesn’t need an AWS account or make any network requests.

Install aws/aws-sdk-php version 3.399.2, then run:

<?php

require 'vendor/autoload.php';

use Aws\Api\Parser\NonSeekableStreamDecodingEventStreamIterator;
use GuzzleHttp\Psr7\BufferStream;

$headers = '';

foreach ([
    ':message-type' => 'event',
    ':event-type' => 'messageStop',
    ':content-type' => 'application/json',
] as $name => $value) {
    $headers .= chr(strlen($name)).$name.chr(7)
        .pack('n', strlen($value)).$value;
}

$payload = '{"stopReason":"end_turn"}';
$prelude = pack('NN', 16 + strlen($headers) + strlen($payload), strlen($headers));
$frame = $prelude.hash('crc32b', $prelude, true).$headers.$payload;
$frame .= hash('crc32b', $frame, true);

$stream = new BufferStream;
$stream->write($frame);

$iterator = new NonSeekableStreamDecodingEventStreamIterator($stream);

var_dump(count(iterator_to_array($iterator)));

Possible Solution

Have valid() check whether there’s a parsed event available, rather than whether the underlying stream has reached EOF.

Additional Information/Context

I also reproduced this through BedrockRuntimeClient::converseStream() using a local HTTP server. It sent messageStop followed by metadata, but only messageStop was returned. Bedrock sends token usage in that final metadata event. ConverseStream documentation.

The existing decoder tests use a php://temp body, which only reports EOF after another read is attempted. BufferStream reports EOF as soon as its last byte is read, exposing the problem.

The same valid() implementation is still present on master. This is separate from #3371; #3373 changes the same decoder to address partial checksum reads.

SDK version used

3.399.2

Environment details

PHP 8.4.25, Ubuntu 24.04.

Generated by Codex, and reviewed by @binaryfire.

Lingua principale
PHP
Stelle
6.2k
Fork
1.3k
Merge medio
2g 4h
PR unite (30g)
10

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aws/aws-sdk-php

Tutte le issue di aws/aws-sdk-php

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.