bug(typescript): agentcore deploy sets up no ADOT/OTel instrumentation for TypeScript agents, silently dropping all 3p telemetry
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Tranquilla
- Stack tecnologico
- aws, docker, node.js, typescript
- Ambito
- build-system, devops, observability, testing-qa
Direzione di ricerca
Inizia da schema-mapper.ts, dal Dockerfile TypeScript, da entrambi i file package.json dei template TypeScript e dal percorso CodeZip in src/lib/packaging/node.ts. Esegui i test esistenti di rendering del Dockerfile e aggiungi la coverage TypeScript indicata. Il lavoro è completato quando gli agenti TypeScript di container e CodeZip configurano il percorso di strumentazione documentato e il comportamento della telemetria viene verificato insieme alla dipendenza sidecar di Runtime in #1270.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
agentcore deploy does not set up any OpenTelemetry / ADOT instrumentation for TypeScript agents. Python agents get zero-code instrumentation via opentelemetry-instrument; TypeScript agents get nothing at any layer. As a result, spans emitted by any 3p instrumentation library (Strands, Vercel AI SDK, or a user's own @opentelemetry/api calls) are silently dropped, and nothing appears in CloudWatch / X-Ray Transaction Search.
This is a regression, not a never-implemented feature — the wiring existed and was removed (see below).
Steps to Reproduce
agentcore create --language TypeScript --sdk Strands --protocol HTTP --build Containeragentcore deploy- Invoke the deployed agent so it produces LLM/tool calls
- Open CloudWatch → Application Signals / X-Ray Transaction Search and look for traces from the agent
Also observable statically, without deploying:
- Generated
Dockerfileends inCMD ["npx", "tsx", "main.ts"]— no instrumentation wrapper - Generated
package.jsoncontains no OTel SDK, only the no-op@opentelemetry/api
Expected Behavior
TypeScript agents get zero-code ADOT instrumentation at parity with Python, so that 3p instrumentation libraries emitting via @opentelemetry/api export to the collector and show up in CloudWatch without any application code changes.
Actual Behavior
No instrumentation is configured. Three independent gaps, each sufficient on its own to produce zero telemetry:
1. enableOtel is hardcoded off for TypeScript — src/cli/operations/agent/generate/schema-mapper.ts:284
const enableOtel = !isMcp && config.language !== 'TypeScript';
2. The TypeScript Dockerfile has no instrumentation branch at all — src/assets/container/typescript/Dockerfile:25
CMD ["npx", "tsx", "main.ts"]
Compare src/assets/container/python/Dockerfile:40-44, which does branch:
{{#if enableOtel}}
CMD ["opentelemetry-instrument", "python", "-m", "{{entrypoint}}"]
{{else}}
CMD ["python", "-m", "{{entrypoint}}"]
{{/if}}
Because no {{#if enableOtel}} block exists in the TS Dockerfile, setting instrumentation.enableOtel: true on a TypeScript agent has no effect — there is nothing for it to render. The schema at src/schema/schemas/agent-env.ts:194 defaults it to true and documents it as "the runtime entrypoint is wrapped with opentelemetry-instrument", which is silently untrue for TypeScript.
3. No OTel SDK dependency or bootstrap in the TS templates. src/assets/typescript/http/strands/base/package.json carries only @opentelemetry/api — the no-op API surface, which discards all spans unless a global provider is registered. src/assets/typescript/http/vercelai/base/package.json has no OTel dependency at all. Neither template registers a provider.
The CodeZip path is affected too: TS CodeZip builds are bundled with esbuild (src/lib/packaging/node.ts:95) and have no Dockerfile to hook, so they need the instrumentation applied via runtime env vars rather than a CMD change.
Origin of the regression
Commit 580cd10b — "fix(templates): remove OTEL, session storage, and gateway from TS templates", merged in #981 (2026-05-14) — removed the working implementation:
- deleted
src/assets/typescript/http/strands/base/otel-register.tsand thevercelaiequivalent, which registered aNodeTracerProvider+MeterProviderwith OTLP exporters - removed
import './otel-register.js';from bothmain.tsfiles - removed 7
@opentelemetry/*dependencies from bothpackage.jsonfiles - flipped
schema-mapper.tsto exclude TypeScript
The OTel removal was one commit inside a broader TS template/streaming PR, so it isn't visible from the PR title.
Interaction with #1270 (important)
Fixing the CLI alone is not sufficient to get traces into CloudWatch. Per #1270, AgentCore Runtime starts the ADOT collector sidecar on localhost:4318 only when it detects opentelemetry-instrument in the container entrypoint, which is Python-specific. A TypeScript entrypoint never matches, so nothing listens on :4318 and OTLP export fails silently even with a correctly registered SDK.
These two need to land together for end-to-end telemetry. Adopting a --require-based ADOT entrypoint (below) may also give the Runtime a detectable signal for starting the sidecar, which is worth confirming with the Runtime team.
Suggested fix
ADOT for Node exists and is current: @aws/aws-distro-opentelemetry-node-autoinstrumentation@0.12.0. True zero-code parity with Python is a NODE_OPTIONS=--require @aws/aws-distro-opentelemetry-node-autoinstrumentation/register entrypoint — a single dependency and no hand-maintained otel-register.ts, unlike the reverted implementation.
Touch points:
src/cli/operations/agent/generate/schema-mapper.ts:284— stop excluding TypeScriptsrc/assets/container/typescript/Dockerfile— add the{{#if enableOtel}}branch- both TS template
package.jsonfiles — add the ADOT distro dependency - TS CodeZip path — set the instrumentation env vars on the runtime (no Dockerfile to hook)
src/assets/__tests__/dockerfile-render.test.ts— currently only exercises the Python Dockerfile; add TS coverage so this cannot silently regress again
CLI Version
0.25.0 (repo package.json, at commit 8fba8160)
- Lingua principale
- TypeScript
- Stelle
- 291
- Fork
- 96
- Merge medio
- 21h 31m
- PR unite (30g)
- 217
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di aws/agentcore-cli
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
aws/agentcore-cli#2395 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
aws/agentcore-cli#2392 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
aws/agentcore-cli#2267 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
aws/agentcore-cli#2258 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
aws/agentcore-cli#2176 ·
Tutte le issue di aws/agentcore-cli
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
bcgov/bc-wallet-mobile#4761 · 1 commento ·
-
external-issue to-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
-
area-deployment area-integrations triage:bot-seen
Difficoltà 2/5 Mezza giornata Idoneità per principianti 86/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
-
refactor
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100