Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Remove the unused Forward Template editor from Messages settings

Chiusa Adatta ai principianti
  • Qualcosa non va?
#9,970 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@atomantic ci sta già lavorando.

Dal 4/10/2026.

  • #9991 di @atomantic — integrata

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
85/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, react
Ambito
backend, frontend, testing-qa

Direzione di ricerca

Inizia in client/src/components/messages/ConfigTab.jsx dallo stato, dal campo e dalla gestione del salvataggio di Forward Template, quindi esamina ConfigTab.test.jsx e server/routes/settings.js:678 per comprendere la sostituzione delle impostazioni annidate. Rimuovi l’editor inerte e il valore predefinito, preservando un valore legacy esistente, e verifica che l’interazione renderizzata mantenga intatto il salvataggio di Reply Template e conversational-tone.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:ui bug effort:low incomplete model:light plan planner:gpt-6-1-sol

Audited 2026-10-04. Slice: Messages configuration, draft generation route, evaluator callers, tests, and history.
Scope: small. Severity: 4/10.

Problem

Messages Settings offers an editable "Forward Template" under Prompt Templates (client/src/components/messages/ConfigTab.jsx:669). The component loads it at :86, changes it at :676, and saves messages.forwardTemplate through Save Config at :193.

No runtime path reads this setting. Repository-wide identifier search finds forwardTemplate only in that configuration component. The actual generator, server/services/messageEvaluator.js:118, chooses templateOverride or msgConfig.replyTemplate at :123. Its HTTP caller (server/routes/messages.js:235) supplies reply options only; the other production caller in server/services/tribeOutreach.js:577 supplies an outreach override. There is no forwarding entry point selecting the saved Forward Template.

Impact and evidence

A user can edit and save a template intended to affect generated drafts, but it changes no generated message. This is an offered inert setting, not a request to add an unrelated forwarding feature.

The editor was introduced by c700d58b4 with the Messages Config page. Current ConfigTab tests cover OAuth actions; evaluator tests cover reply generation, with no forwarding consumer. Static data-flow inspection is sufficient to prove the missing consumer; no provider call or private data was used.

Decided fix: remove the unsupported surface

In client/src/components/messages/ConfigTab.jsx, remove the Forward Template field, DEFAULT_FORWARD_TEMPLATE, and its editable local state. Do not initialize or save a default for this unsupported feature. Keep the functional Reply Template and conversational-tone controls.
Preserve an existing stored messages.forwardTemplate as opaque legacy passthrough, only when the fetched setting actually contains that key. PUT /api/settings replaces the nested messages slice at server/routes/settings.js:678, so simply omitting it on save would discard the original value. Retain that original key (including an intentionally empty value) when saving supported fields, without inventing a default. Do not add a migration or change global settings merge semantics. A future forwarding workflow can deliberately reuse those values when it supplies a real consumer.

Add a focused rendered configuration regression in ConfigTab.test.jsx: the inert field is absent and saving a Reply Template still sends the supported settings without introducing a default forwardTemplate; an existing legacy value round-trips unchanged. No generation behavior should change.

Dispatch: model:light for a well-specified removal in one component; effort:low because the consumer search proves the setting has no runtime dependency.

Acceptance criteria

  • Messages Settings offers no Forward Template editor and no longer initializes or writes a replacement default for it.
  • Reply Template and conversational tone remain editable and saved.
  • Saving supported settings preserves a pre-existing stored Forward Template instead of clearing it.
  • A rendered interaction regression verifies the supported Save Config payload and the absent inert control.
Lingua principale
JavaScript
Stelle
38
Fork
32
Merge medio
43m
PR unite (30g)
984

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di atomantic/PortOS

Tutte le issue di atomantic/PortOS

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.