Generate Push by default for SDKs that already released it

Aperta
#2,043 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@ChiragAgg5k ci sta già lavorando.

Dal 14/10/2026.

  • #2042 di @ChiragAgg5k — chiusa senza merge

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Tracks PR #2042.

Plan

Goal

Stop a regeneration from deleting Push from SDKs that already released it. Since #2037 Push is off by default, but sdk-for-android has shipped the Push service since 29.0.0 and sdk-for-go has shipped the topic package since v7.10.0 (per the PR description), so those SDKs should keep generating it by default.

What changes
  • PR #2042 (feat/push-default-for-released): adds Language::hasReleasedPush() in src/SDK/Language.php (defaults to false), overridden to true in src/SDK/Language/Android.php and src/SDK/Language/Go.php, and back to false in src/SDK/Language/CLI.php (CLI extends Go).
  • src/SDK/SDK.php: the constructor now calls setPush($language->hasReleasedPush()); an explicit setPush(true|false) still wins.
  • example.php: only calls setPush() when SDK_GEN_PUSH is set, so the language default applies otherwise.
  • tests/generation/GenerationTest.php: adds testPushDefaultsToWhetherTheSdkReleasedIt, checking the default for every language plus both explicit overrides.
Remaining steps

None for this ticket. PR #2042 is the full generator change. Adding another language to the released list later is a one-line hasReleasedPush() override when that SDK ships Push.

Done when
  • PR #2042 is merged
  • Android and Go generate Push/Topic by default; every other language (including CLI) leaves it out unless setPush(true) is called
  • testPushDefaultsToWhetherTheSdkReleasedIt and the generation suite pass
Lingua principale
Twig
Stelle
330
Fork
212
Merge medio
12h 3m
PR unite (30g)
131

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di appwrite/sdk-generator

Tutte le issue di appwrite/sdk-generator

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.