[Bug]: TCPForwarderTest fails intermittently on macOS 27.2 after ConnectHandlerRaceTest: loopback connections are reset before accept
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 50/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- swift
- Ambito
- networking, testing
Direzione di ricerca
Start with TCPForwarderTest.swift at the reported failure lines and compare testTCPForwarder with ConnectHandlerRaceTest.testRapidConnectDisconnect, the parallel test implicated by the reproduction. Run the supplied filtered SocketForwarderTests command repeatedly, then compare parallel and --no-parallel runs. Done means identifying and addressing the cause so the parallel suite passes reliably without dropping client connections.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
I have done the following
- I have searched the existing issues
- If possible, I've reproduced the issue using the 'main' branch of this project
Steps to reproduce
Run the SocketForwarderTests target repeatedly on main (16e8d48). The failure is intermittent.
swift test --skip-build -c debug -Xswiftc -warnings-as-errors -Xswiftc -enable-testing --filter SocketForwarderTests
Results on my machine, with the conditions interleaved in blocks:
| Condition | Failures |
|---|---|
TCPForwarderTest alone |
0 / 20 |
TCPForwarderTest|ConnectHandlerRaceTest |
7 / 20 |
SocketForwarderTests |
19 / 40 |
SocketForwarderTests, with the two suites nested under one @Suite(.serialized) parent |
32 / 40 |
Pair, with the stress test pointed at a plain echo listener instead of a TCPForwarder |
8 / 15 |
| Pair, with the stress test opening 100 connections instead of 500 | 4 / 15 |
The samples are small and the machine was under load for some blocks, so the rates are rough. An earlier batch on c05a560 gave 0 / 60 for TCPForwarderTest alone and 0 / 60 with --no-parallel; I have not rerun --no-parallel and can't explain why it differs from the serialized result.
I have only seen this on my own machine. In the CI logs I looked at (macOS 27.0), testTCPForwarder passed while starting at the same moment as testRapidConnectDisconnect.
Problem description
TCPForwarderTest.testTCPForwarder fails intermittently when ConnectHandlerRaceTest.testRapidConnectDisconnect is part of the same test run. The two do not need to overlap: with the suites serialized, the stress test finished first in every run, and testTCPForwarder, started right after it, still failed. It fails in one of two ways.
Some of the 100 clients get no echo back:
✘ Test testTCPForwarder() recorded an issue at TCPForwarderTest.swift:108:13: Expectation failed: sortedResponses[i] == "\(i): success-tcp"
Or a client read fails:
✘ Test testTCPForwarder() recorded an issue at TCPForwarderTest.swift:25:6: Caught error: read(descriptor:pointer:size:): Connection reset by peer) (errno: 54)
With temporary tracing added to the forwarder and the tests, the failing connections die before either listener accepts them:
- Clients that fail with
Connection reset by peerhad connected and written, but the proxy never accepted them;ConnectHandler.channelActivenever ran for those connections. - Clients that get no echo were accepted by the proxy, and the backend
connectsucceeded, but the echo server never accepted that backend connection. The backend read then failed withECONNRESETandGlueHandler.errorCaughtclosed the frontend, which is the intended behaviour. In one failing run, 100 backend connects succeeded, the echo server accepted 76, and the other 24 were reset. - During failing runs,
netstat -Lanshowed the test's own listeners holding 30-50 connections in the incomplete queue for hundreds of milliseconds. Neither listener has more than 100 pending connections, so the backlog (clamped tokern.ipc.somaxconn, 128) is not exceeded.
So the forwarder does not appear to be at fault: it reacts to a backend connection that was reset underneath it. The failure also occurs when the stress test targets a plain listener, with no TCPForwarder on its side at all.
What I can't explain is why loopback connections are reset before accept for a short time after a burst of connect/close on a different listener. I could not read TCP drop counters or capture packets without root, and I have only tested on macOS 27.2.
I don't have a fix to propose. Serializing the suites does not avoid it, and a delay or a retry in the test would only hide it. I'd expect the suite to pass reliably, so I'm leaving this open in case it shows up elsewhere. Feel free to close it if it does not reproduce outside my setup.
Environment
- OS: macOS 27.2 (26B123)
- Xcode: Version 27.2 (27B52)
- Container: main (16e8d48)
Code of Conduct
- I agree to follow this project's Code of Conduct
- Lingua principale
- Swift
- Stelle
- 51.9k
- Fork
- 1.8k
- Merge medio
- 2g 3h
- PR unite (30g)
- 27
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apple/container
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: Kernel download ignores credentials in HTTPS_PROXY and fails with proxyAuthenticationRequiredAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
apple/container#2499 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: `container machine logs -f` exits immediately when the log is emptyForse già presa @srivilliamsai l’ha presa 5 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
apple/container#2492 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: Intermittent failure in PathUtilsTests.testNewDirectoryIsExcludedAndExistingChoiceIsKeptAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
apple/container#2474 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[Request]: container ls --filter label=key=valueForse già presa @kavix l’ha presa 21 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
apple/container#2403 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di apple/container
Issue simili
-
compiler diagnostics quality ownership SIL ownership
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 64/100
I maintainer di solito rispondono entro 1 giorno
-
T-Defect
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
element-hq/element-x-ios#6536 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Switch to new string APIApertafxios-coreexperience
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
mozilla-mobile/firefox-ios#36661 ·
I maintainer di solito rispondono entro 1 giorno
-
needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
manaflow-ai/cmux#45713 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno