Laravel: Disabling Pagination Causes 403 on Policy-Protected Collection Endpoints
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- laravel, php
- Ambito
- api, authorization, backend
Direzione di ricerca
Inizia con CollectionProvider.php e ResourceAccessChecker.php, quindi esamina AccessCheckerProvider.php nel percorso di negazione dell'accesso. Riproduci le due richieste di collection con la paginazione abilitata e disabilitata usando una policy il cui viewAny() restituisca true. Il lavoro è completato quando gli endpoint di collection protetti da policy non restituiscono più 403 esclusivamente perché la paginazione è disabilitata, con copertura di regressione per pagination=false e pagination=0.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
API Platform version(s) affected: 4.3.17 (api-platform/laravel)
Description
Any GetCollection operation that has a Policy/security expression (resolved via a Laravel Policy's viewAny() method, e.g. through the standard Gate::getPolicyFor($model) naming-convention resolution) unconditionally returns 403 Access Denied when the request disables client-side pagination (?pagination=false or ?pagination=0), regardless of authentication state or the policy's actual logic — even when viewAny() unconditionally returns true.
Root cause: ApiPlatform\Laravel\Security\ResourceAccessChecker::isGranted() special-cases the Paginator wrapper class when deciding what object to pass to Gate::allows():
public function isGranted(string $resourceClass, string $expression, array $extraVariables = []): bool
{
$object = $extraVariables['object'] ?? null;
return Gate::allows(
$expression,
($object instanceof Paginator || null === $object) ? $resourceClass : $object
);
}
When pagination is enabled, ApiPlatform\Laravel\Eloquent\State\CollectionProvider::provide() returns an ApiPlatform\Laravel\Eloquent\Paginator instance, so $object instanceof Paginator is true, and Gate::allows($expression, $resourceClass) is called with the resource class string — which correctly resolves to the model's Policy class and calls viewAny().
When pagination is disabled, the same provider instead returns a plain Illuminate\Database\Eloquent\Collection (see CollectionProvider::provide(), the false === $this->pagination->isEnabled(...) branch: return $query->get();). This is not a Paginator, so ResourceAccessChecker passes the Collection object itself to Gate::allows($expression, $collection). Laravel's Gate then tries to resolve a policy based on get_class($collection) (Illuminate\Database\Eloquent\Collection), finds no policy registered for that class, and — absent any other applicable ability/Gate::before() override — denies the request by default.
The result: disabling pagination on any policy-protected collection endpoint always 403s, independent of the actual authorization rule.
How to reproduce
Any Eloquent resource with a Policy providing viewAny():
class PaymentMethodPolicy
{
public function viewAny(?RemoteUser $user): bool
{
return true; // unconditionally public
}
}
GET /api/payment_methods
→ 200 OK (Gate::allows('viewAny', PaymentMethod::class) — resolves the policy correctly)
GET /api/payment_methods?pagination=false
→ 403 {"detail":"Access Denied."}
(reproduces identically authenticated or unauthenticated)
GET /api/payment_methods?pagination=0
→ 403 (same)
Possible Solution
ResourceAccessChecker::isGranted() should pass the resource class string whenever $object is a bare collection of resources (i.e., not a single instance of the resource itself) rather than only special-casing Paginator. For example, also treat PartialPaginator and plain Illuminate\Support\Collection/Illuminate\Database\Eloquent\Collection instances the same way Paginator is treated:
$isCollectionLike = $object instanceof Paginator
|| $object instanceof PartialPaginator
|| $object instanceof \Illuminate\Support\Collection;
return Gate::allows(
$expression,
($isCollectionLike || null === $object) ? $resourceClass : $object
);
Additional Context
CollectionProvider:vendor/api-platform/laravel/Eloquent/State/CollectionProvider.phpResourceAccessChecker:vendor/api-platform/laravel/Security/ResourceAccessChecker.phpAccessCheckerProvider(throw site):vendor/api-platform/laravel/State/AccessCheckerProvider.php- This was found while debugging a checkout page that couldn't load any payment methods; it was initially conflated with an unrelated
BooleanFiltervalidation bug (seedocs/bug-reports/api-platform-boolean-filter-validation.md) because both bugs happened to be triggered by parameters on the same request (?enabled=true&pagination=false) and both produce failure responses that look superficially similar during triage (422 vs 403) unless isolated parameter-by-parameter. - Workaround applied in our app: stopped disabling client-side pagination on this endpoint (removed
pagination: falsefrom the frontend query) — the resource's default page size (20) is more than sufficient for a payment-methods list, so no functional loss.
- Lingua principale
- PHP
- Stelle
- 2.6k
- Fork
- 982
- Merge medio
- 1g 16h
- PR unite (30g)
- 59
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di api-platform/core
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
api-platform/core#8564 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
api-platform/core#8495 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
api-platform/core#8471 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
api-platform/core#8475 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
api-platform/core#8447 ·
Tutte le issue di api-platform/core
Issue simili
-
Solved site promotion gate fails on runner PHP patch drift (expects 8.2.33, runner installs 8.2.34) Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Automattic/blocks-engine#2161 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
Automattic/static-site-importer#1824 ·
-
[Chore] Keep one viget-block-generator skill and replicate it, instead of four tracked copies Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
Cannot reset column width Aperta0. Needs triage bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
0. Needs triage 35-feedback bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100