ObjectMapper: PersistProcessor::handleLazyObjectRelations() breaks cascade persist of new relations with app-assigned ids (UUID in constructor)
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 55/100
Direzione di ricerca
Inizia individuando PersistProcessor::handleLazyObjectRelations() e le fixture/i test esistenti di Issue7689 menzionati nell’issue. Riproduci un POST mappato con una relazione annidata il cui UUID viene assegnato nel costruttore. Il lavoro è completato quando le nuove entità correlate non gestite con non-null ids vengono lasciate a cascade persist, mentre i riferimenti alle righe esistenti continuano a comportarsi correttamente.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
API Platform version(s) affected: 4.3.5 (also present on 4.3 and main branches)
Description
When using the ObjectMapper (stateOptions + input DTO) on a Post operation, creating a new nested related entity fails with a foreign key constraint violation when the related entity uses an application-assigned identifier (e.g. a UUID generated in the constructor).
PersistProcessor::handleLazyObjectRelations() runs for every mapped operation ($operation->canMap()) and replaces any relation value that is not managed but has non-null identifiers with $manager->getReference($class, $identifiers):
// Do not get reference for partial objects or objects with null identifiers
if (!$identifiers || \count($identifiers) !== \count(array_filter($identifiers, static fn ($v) => null !== $v))) {
continue;
}
$reflectionProperty->setValue($data, $relManager->getReference($relClass, $identifiers));
This heuristic assumes "has an id" means "row exists in the database". That holds for #[ORM\GeneratedValue] entities (id is null pre-flush, so the swap is skipped and cascade: ['persist'] works — this is the case covered by the Issue7689 fixtures where Issue7689Category has a nullable auto-increment id). But with app-assigned ids (UUIDv4/v7 assigned in the constructor, a common pattern), a freshly mapped nested entity is indistinguishable from a reference to an existing one:
- The mapper creates a new related entity; its constructor assigns a UUID.
handleLazyObjectRelations()sees an unmanaged object with a non-null identifier and swaps it for agetReference()proxy.- The proxy counts as managed, so
cascade: ['persist']on the owning side never persists it. - Flush inserts the owning entity with an FK pointing to a nonexistent row:
SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row:
a foreign key constraint fails (FOREIGN KEY ("condition_id") REFERENCES "..." ("id"))
How to reproduce
Entities (owning side cascades persist to the relation; both use constructor-assigned UUIDs):
#[ORM\Entity]
class TaskRule
{
public function __construct(
#[ORM\ManyToOne(targetEntity: TaskRuleCondition::class, cascade: ['persist'])]
#[ORM\JoinColumn(nullable: true)]
public ?TaskRuleCondition $condition = null,
#[ORM\Id, ORM\Column]
private(set) UuidV7 $id = new UuidV7(),
) {
}
}
#[ORM\Entity]
class TaskRuleCondition
{
public function __construct(
#[ORM\Column]
public string $completeWhen,
#[ORM\Id, ORM\Column]
private(set) UuidV7 $id = new UuidV7(),
) {
}
}
Input DTOs mapped with the ObjectMapper:
#[Map(target: TaskRule::class)]
final readonly class TaskRulePostInput
{
public function __construct(
public ?TaskRuleConditionInput $condition = null,
) {
}
}
POST with a nested condition payload -> FK violation on flush. Persisting the owning entity manually in a custom processor before PersistProcessor runs works around it, because the cascade marks the relation managed and handleLazyObjectRelations() then skips it via the contains() check.
Possible Solution
Only swap values that are genuinely placeholders for existing rows, instead of assuming any unmanaged object with an id is one:
- only replace actual uninitialized lazy objects (
ReflectionClass::isUninitializedLazyObject()on PHP >= 8.4), and/or - consult
UnitOfWork::getEntityState($value)—STATE_NEWobjects should be left alone so cascade persist can handle them.
Additional Context
- Introduced/extended in cc2f8855 ("fix(doctrine): post with mapped relation", #7689) — the accompanying test fixtures only cover DB-generated ids, where new entities still have null ids pre-flush.
- Related but distinct: #7735/#7738 fixed uninitialized-property crashes in the same method; #7801 concerns nested mapping on the output side.
- Lingua principale
- PHP
- Stelle
- 2.6k
- Fork
- 982
- Merge medio
- 1g 16h
- PR unite (30g)
- 59
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di api-platform/core
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
api-platform/core#8573 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
api-platform/core#8571 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
api-platform/core#8564 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
api-platform/core#8495 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
api-platform/core#8471 ·
Tutte le issue di api-platform/core
Issue simili
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
Automattic/safe-publish#594 ·
-
needs-triage Platform(Default)
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
HttpClient
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
symfony/symfony-docs#23092 ·
-
sync-en
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
-
sync-en
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 95/100