[Bug] CheckpointFile skips valid backup recovery when the primary numeric header is malformed
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start by reading CheckpointFile.read(String) and the public read() recovery path; also inspect EpochFileCache.initCacheFromFile and the existing remoting CheckpointFileTest tests. Reproduce with a malformed primary numeric header and a valid .bak, then verify recovery, failure cause and path when both headers are invalid, and regression behavior for valid primaries and CRC/count mismatches. PR #11032 is unrelated; open PR #11063 already proposes this fix.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Before Creating the Bug Report
-
I found a bug, not just asking a question, which should be created in GitHub Discussions.
-
I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
-
I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
Runtime platform environment
Windows 11; local checkpoint files and native common/remoting module tests. No live broker or HA failover claim.
RocketMQ version
develop, revision 5.5.1, commit 57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3.
JDK Version
OpenJDK 1.8.0_302 (GraalVM CE 21.2.0), Maven 3.6.3.
Describe the Bug
CheckpointFile.read(String) parses the entry count and CRC with Integer.parseInt. An empty, truncated or nonnumeric header throws NumberFormatException, while public read() only catches IOException to recover from .bak. A valid backup is therefore ignored. EpochFileCache.initCacheFromFile also only catches IOException.
Steps to Reproduce
- Create a CheckpointFile whose serializer writes and reads the entry string unchanged.
- Write Collections.singletonList("saved") and copy the checkpoint file to checkpoint.getBackFilePath().
- Replace the primary file with "invalid\n0\nvalue\n" (or an empty file).
- Call checkpoint.read().
The valid backup can be read on its own; the malformed primary prevents reaching it.
What Did You Expect to See?
Malformed numeric headers enter the existing IOException recovery path and the valid backup is returned. If the backup header is also invalid, the final failure is IOException with the failing path and NumberFormatException as its cause.
What Did You See Instead?
An unchecked NumberFormatException escapes from parsing the primary header instead of loading the valid backup.
Additional Context
The proposed fix only wraps the two numeric header parses; serializer exceptions are not swallowed. Existing valid-primary precedence and CRC/count mismatch behavior are regression controls. Six new header tests plus the three existing remoting CheckpointFileTest tests pass on the independent patch (9 native tests, 0 failures/errors/skips). Baseline native Surefire reproduced the NumberFormatException and stopped after the first failure; not all six new methods ran before the fix. Checkstyle/SpotBugs pass.
PR #11032 concerns empty checkpoint state and does not handle malformed numeric headers. Issue/PR/discussion searches did not identify this header-recovery fix.
AI assistance: OpenAI Codex was used for investigation, implementation and tests.
- Lingua principale
- Java
- Stelle
- 22.7k
- Fork
- 12k
- Merge medio
- 4g 20h
- PR unite (30g)
- 11
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apache/rocketmq
-
[Bug] RemotingHelper.connect swaps the socket send and receive buffer configurationForse già presa @amalsaidov l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
CompressionType.of fails under the Turkish localeForse già presa @sharanggupta l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
I maintainer di solito rispondono entro 1 giorno
-
[rocketmq-client-python] TransactionMQProducer allocates an unused producer during initializationAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
[Bug] notifyMasterOnline aborts the long-polling wake-up with a NullPointerException when an arrival drains a bucket firstForse già presa @iloveeyjafjalla l’ha presa 29 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
apache/rocketmq#11441 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[Enhancement] FilterFactory duplicate-registration and unregister semantics lack testsForse già presa @chennaji9 l’ha presa 34 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
apache/rocketmq#11340 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di apache/rocketmq
Issue simili
-
bug emitter:client:csharp
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
microsoft/typespec#12572 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
GCC 15.2: -Wcast-qual warning - cast discards const qualifier from pointer target type (H5trace.c)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
I maintainer di solito rispondono entro 1 giorno
-
needs-area-label
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 2 giorni
-
area/ai area/backend component/zeebe kind/task
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
spAnser/reacharound#38 ·