[Bug] MessageTest fails to build with GCC 15.3.0 and 16.2.1 (-Werror=stringop-truncation)

Aperta
  • Qualcosa non va?
#621 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

@davlgd ci sta già lavorando.

Dal 31/10/2026.

  • #622 di @davlgd — aperta

Valutazione

Difficoltà
1/5
Tempo stimato
Meno di un'ora
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
cmake, cpp
Ambito
testing

Direzione di ricerca

The warning comes from testAllocatedContents in tests/MessageTest.cc around line 53, where strncpy copies str.length() bytes. Check the setAllocatedContent() call and the msg.getLength() comparison that follow. A linked pull request (#622) is already open against this issue, so review that first. Done means the MessageTest.* tests build under the top-level -Werror and pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Search before asking
  • I searched in the issues and found nothing similar.
Version

pulsar-client-cpp 4.2.0 on Exherbo Linux (x86_64), built with GCC 15.3.0, -O2 and -DBUILD_TESTS=ON. Also reproduced on Arch Linux with GCC 16.2.1 and protobuf 36.1; there, the build used -Wno-error=unused-result to get past a separate protobuf build failure, with -Werror=stringop-truncation still enabled. The same call is present on main at f71d7e99019d58b1d11858f05ff0dc83b718627b (source inspection).

Minimal reproduce step

With the dependencies installed and GCC 15.3.0:

cmake -S . -B build -DBUILD_TESTS=ON -DCMAKE_CXX_FLAGS=-O2
cmake --build build

On Arch Linux (GCC 16.2.1, protobuf 36.1):

cmake -S . -B build-arch -DBUILD_TESTS=ON "-DCMAKE_CXX_FLAGS=-O2 -Wno-error=unused-result" -DCMAKE_C_FLAGS=-O2
cmake --build build-arch --target pulsar-tests

The top-level CMakeLists.txt adds -Werror, so tests/MessageTest.cc fails to compile. Failing build log: https://gitlab.exherbo.org/davlgd/CleverCloud/-/jobs/223191

What did you expect to see?

The tests build.

What did you see instead?
tests/MessageTest.cc:53:12: error: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying 7 bytes from a string of the same length [-Werror=stringop-truncation]
   53 |     strncpy(content, str.c_str(), str.length());
      |     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
Anything else?

testAllocatedContents copies str.length() bytes with strncpy, so the terminating NUL is never written. No NUL terminator is required in this test: setAllocatedContent() takes a pointer and an explicit byte count, and the comparison is bounded by msg.getLength(). GCC's documentation uses this strncpy(d, s, strlen(s)) pattern as its example for this warning and suggests memcpy instead. With strncpy replaced by memcpy for the same byte count, all 10 MessageTest.* tests passed on Arch Linux with GCC 16.2.1 and -O2 -Wno-error=unused-result.

Are you willing to submit a PR?
  • I'm willing to submit a PR!
Lingua principale
C++
Stelle
72
Fork
93
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/pulsar-client-cpp

Tutte le issue di apache/pulsar-client-cpp

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.