[Bug] Configured Variant shredding schema without field IDs is rejected unlike Java Paimon
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 68/100
Direzione di ricerca
Start at VariantShreddingWritePlan::FromConfiguredSchema, then trace DataTypeJsonParser::ParseRowType and DataField::FromJson. Compare the configured-schema behavior with Java Paimon’s all-or-none field-ID handling, and inspect existing Variant shredding tests. Done means omitted IDs receive deterministic traversal-order IDs, explicit IDs remain unchanged, partial IDs produce a clear rejection, and configured shredding round trips with the generated physical schema.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Search before asking
- I searched in the issues and found nothing similar.
Paimon-cpp version
- Apache Paimon C++ v0.3.0 (
efbfc848). - The problem is also present on current
main(ccfe346670f32b82d7c9139a8f3d356c33dc5b7d). - Java behavior used for comparison: Apache Paimon 1.4.2.
Minimal reproduce step
Create a logical schema with a top-level Variant column and configure variant.shreddingSchema with a valid ROW type whose fields omit every id, for example:
{
"type": "ROW",
"fields": [
{
"name": "payload",
"type": {
"type": "ROW",
"fields": [
{"name": "age", "type": "INT"},
{"name": "profile", "type": {
"type": "ROW",
"fields": [{"name": "city", "type": "STRING"}]
}}
]
}
}
]
}
Pass this value to VariantShreddingWritePlan::FromConfiguredSchema (normally through variant.shreddingSchema or its Parquet fallback option) and open a writer.
Paimon-cpp rejects the configuration while deserializing the first DataField, because DataField::FromJson unconditionally requires the id key. In an embedding engine the propagated exception is equivalent to:
key 'id' must exist
The same schema is accepted by Java Paimon 1.4.2. DataTypeJsonParser.parseDataType starts an AtomicInteger at -1 and assigns deterministic IDs in traversal order when all field IDs are omitted.
What doesn't meet your expectations?
Expected behavior
Paimon-cpp should accept the same configured Variant shredding schema JSON as Java Paimon:
- If every ROW field omits
id, assign deterministic IDs in the same traversal order as Java, starting at 0. - If every ROW field provides
id, preserve those IDs. - If IDs are only partially present, reject the schema with an explicit diagnostic such as
Partial field id is not allowed.
Actual behavior
Paimon-cpp accepts only the second form. A valid all-ID-omitted schema accepted by Java is rejected before the Variant shredding plan can be created.
This creates a cross-language compatibility gap for engines that consume table options written by Java/Spark. Such engines must currently route an otherwise supported Variant write back to the Java SDK solely because the configured schema omits optional field IDs.
Anything else?
The mismatch comes from the generic JSON parsing path:
VariantShreddingWritePlan::FromConfiguredSchemadelegates the configured ROW JSON toDataTypeJsonParser::ParseType.DataTypeJsonParser::ParseRowTypedeserializes every ROW child as aDataField.DataField::FromJsonrequiresidunconditionally.
A contained fix could normalize the configured schema before normal DataType parsing: recursively count ID presence across ROW fields; generate preorder IDs only when none are present; preserve the current error behavior for partial IDs. Alternatively, the generic DataTypeJsonParser can implement Java's all-or-none semantics if that behavior is desired for every DataType JSON consumer.
Suggested regression coverage:
- all IDs omitted, including nested ROW/ARRAY/MAP descendants;
- all IDs explicitly present;
- partially present IDs are rejected;
- configured shredding write/read round trip uses the generated IDs in the physical Parquet schema.
This is separate from #344: that issue concerns missing IDs in the generated physical shredded Variant subtree, whereas this issue concerns parsing IDs in the user-configured logical shredding schema.
Are you willing to submit a PR?
- I'm willing to submit a PR!
- Lingua principale
- C++
- Stelle
- 65
- Fork
- 29
- Merge medio
- 2g 30m
- PR unite (30g)
- 77
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apache/paimon-cpp
-
enhancement
apache/paimon-cpp#381 · 1 assegnatario ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 30/100
apache/paimon-cpp#375 · 1 assegnatario ·
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 30/100
apache/paimon-cpp#369 · 1 assegnatario ·
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 45/100
apache/paimon-cpp#361 · 1 assegnatario ·
-
enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
apache/paimon-cpp#325 · 1 assegnatario ·
Tutte le issue di apache/paimon-cpp
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
games-on-whales/wolf#509 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
-
bug-unconfirmed
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
NVIDIA/cuda-samples#453 ·