[FEATURE] FAT: Add compile-time read-only configuration to reduce binary size

Aperta
  • Qualcosa non va?
#21,390 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
c
Ambito
operating-systems

Direzione di ricerca

Start with the g_fat_operations table in fs/fat/fs_fat32.c to see which write entry points it references, then read fs/fat/Kconfig to see where a new CONFIG_FS_FAT_READONLY option would sit. Done means that with the option enabled, write operations return -EROFS, the write-only helpers are compiled out, and read and directory paths behave as before. With the option disabled, the build should be unchanged. Agree the scope with maintainers first, since the issue does not list which functions to remove.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Type: Enhancement
Is your feature request related to a problem? Please describe.

Currently, FAT keeps its write-side functions reachable through g_fat_operations in fs/fat/fs_fat32.c, even when an application only needs read access.

This prevents the linker from removing unused write-related code, increasing binary size on resource-constrained targets.

There is currently no compile-time read-only option in fs/fat/Kconfig. The existing FATATTR_READONLY attribute only applies to individual files.

This also relates to the binary-size discussion in #20414.

Describe the solution you'd like

Introduce an optional CONFIG_FS_FAT_READONLY configuration.

When enabled, it should:

  • Exclude unnecessary write-side functions and helpers at compile time.
  • Reject write operations gracefully, preferably with -EROFS.
  • Preserve normal read operations, directory enumeration and filesystem lifecycle.

The implementation should also ensure that write-related references in g_fat_operations don't prevent dead-code elimination.

The existing FAT behaviour should remain unchanged when the option is disabled.

Describe alternatives you've considered
  • Relying on linker garbage collection alone, which cannot remove functions referenced by the operations table.
  • Using FATATTR_READONLY, which only protects individual files.
  • Runtime read-only handling, which doesn't eliminate the unused write-side code.

A compile-time option seems more suitable for systems that never need FAT write functionality.

Verification
  • I have verified before submitting the report.
Lingua principale
C
Stelle
4.1k
Fork
1.7k
Merge medio
1g 3h
PR unite (30g)
872

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/nuttx

Tutte le issue di apache/nuttx

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.