Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Stop committing the framework's own .claude/settings.json; ship it as a template

Chiusa
  • Qualcosa non va?
#1,639 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #1671 di @potiuk — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github-actions, python
Ambito
security, tooling

Direzione di ricerca

Start with the root .claude/settings.json and the sandbox-lint wiring in .github/workflows/sandbox-lint.yml, tools/sandbox-lint/expected.json and .asf.yaml. Then check the fingerprint in plugins/magpie-setup/skills/setup/setup_preflight/isolated.py and the exclusion in .pre-commit-config.yaml. Done means the template lives at a tracked path, the repo's own .claude/settings.json is gitignored, CI lint still passes against the template, and the doc links point at it.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

capability:platform enhancement family:ci family:setup
What should happen

The Magpie repository stops committing .claude/settings.json. Its contents become a template, plus a documented step that contributors (and the secure-setup install) follow to put it in place locally.

Why

The file in this repository is the maintainers' working configuration, not something a contributor's agent should silently inherit on clone. It mixes two things:

  • the sandbox and permission baseline (sandbox.*, permissions.*);
  • the self-adoption wiring (extraKnownMarketplaces, enabledPlugins).

Because it is committed, every change to it is a repository change. Contributors also get the maintainers' choices whether or not they want them, and a cloned checkout can never differ from the baseline without a dirty tree.

Which layer

The repository root .claude/settings.json, plus every surface that references it:

  • .github/workflows/sandbox-lint.yml and tools/sandbox-lint/expected.json (the lint baseline);
  • .asf.yaml (the required sandbox-lint check);
  • .pre-commit-config.yaml (the exclusion it gets);
  • plugins/magpie-setup/skills/setup/setup_preflight/isolated.py (it is listed as a dogfooded file);
  • docs/security/threat-model.md (mitigation M.14 cites its allowedDomains);
  • docs/setup/secure-agent-setup.md, docs/setup/secure-agent-internals.md, docs/spec-driven-development.md and plugins/magpie-utilities/skills/write-skill/security-checklist.md (they link it as the block to copy).
Boundary conditions
  • Ship the template at a tracked path outside .claude/ (for example tools/agent-isolation/claude-settings.template.json), and gitignore .claude/settings.json in this repository.
  • Retarget sandbox-lint, the preflight fingerprint and the doc links at the template, so the baseline stays linted and required in CI.
  • Add the contributor step to the contributor docs and to setup-isolated-setup-install: copy or merge the template into .claude/settings.json (or settings.local.json), with isolated-setup-verify reporting when it is missing.
  • An adopter's adopt still writes its own committed .claude/settings.json floor. This issue is about the Magpie repository only.
Out of scope

Changing the contents of the baseline.

Lingua principale
Python
Stelle
118
Fork
102
Merge medio
13h 35m
PR unite (30g)
362

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/magpie

Tutte le issue di apache/magpie

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.