No client-side time bound after the TCP handshake (RPC reads, Drop teardown, and TLS handshake can block forever)
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 56/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- rust
- Ambito
- networking
Direzione di ricerca
Inizia in connection/mod.rs, da connect_stream, e segui il percorso per vedere dove il socket raggiunge tls_handshake; quindi esamina ConnectionOptions e SessionConfig. Controlla i percorsi di Drop per Session, SessionPool, SessionDataSet e PooledSession::release, insieme ai test TLS esistenti. Il lavoro è completato quando le operazioni sul socket, la configurazione TLS, le letture RPC e le RPC di Drop best-effort sono soggette a un limite e i casi con un server silenzioso non si bloccano più indefinitamente.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
After TcpStream::connect_timeout succeeds, the client has no time bound on any socket operation. connect_timeout only covers the TCP handshake (connection/mod.rs connect_stream), and there is no set_read_timeout / set_write_timeout / SO_KEEPALIVE anywhere in the crate. SessionConfig::query_timeout_ms is a request-body field enforced server-side and does not cover openSession, closeSession, or the wire read itself. Every Thrift read after a successful handshake is therefore an unbounded blocking read.
This is one root cause with three manifestations (fix points in different places, one fix: a socket-level I/O timeout set before the TLS handshake and every RPC read):
F1 — ordinary RPCs hang forever
Reproduced with a local listener that completes the TCP handshake and then never replies (equivalent to a long JVM GC pause, a silently-dropping firewall, or an accepting-but-not-forwarding LB):
Session::open()withconnect_timeout = 200mswas still blocked after 12s (the block is in theopenSessionread, past the connect timeout's scope).- With a fake server that answers
openSession+requestStatementIdand then goes silent,execute_non_queryblocked >8s withenable_auto_reconnect = trueandmax_reconnect_attempts = 3.with_retryonly reacts to errors, and a wedged read produces none, so auto-reconnect never fires against exactly the failure it is meant to cover. - Control: with the port closed, the same call returned in 176us.
F2 — Drop becomes non-recoverable
Four destructors send RPCs that wait for a response: Drop for Session (close() → closeSession), Drop for SessionPool (serial entry.session.close() for every idle session), Drop for SessionDataSet (close_query → closeOperation), and the pool-closed branch of PooledSession::release. A destructor cannot return an error, be cancelled, or be given a timeout, and the failures are swallowed (let _ = / log::debug!). Reproduced against the same silent server:
Session::open()succeeds, thendrop(s)blocks >12s.SessionPool::new(min_size = 1)thendrop(pool)blocks >12s; with 8 idle sessions only the first close is attempted andnotify_all()is never reached.pool.close()followed by a guard going out of scope blocks >12s in the closed branch ofrelease().- A panic unwind through a bare
Session/SessionPoolnever completes.
The best-effort RPC-on-drop semantics match the C#/Node SDKs and should stay; they just need the socket-level bound to become best-effort again.
F3 — TLS handshake has no deadline
tls_handshake runs rustls complete_io on a blocking socket with no read timeout. Reproduced with use_ssl = true, connect_timeout = 200ms pointed at a non-TLS IoTDB RPC port: the client sends ClientHello and waits for ServerHello; the plain framed transport misreads the record bytes as a ~369MB frame length and both sides wait forever. Session::open() was still blocked after 15s. The existing TLS tests use listeners that close the connection, so the client escapes on EOF and this shape is not covered.
Proposed fix
- Add a socket I/O timeout (read + write) to
ConnectionOptions/SessionConfig, applied to the socket immediately after connect and before the TLS handshake, so every read/write — TLS handshake,openSession, all RPCs,closeSessionon drop — is bounded by it. - With a timeout in place, wedged reads surface as
Error::Thrift, sowith_retry/reconnect actually engages, and the drop paths become bounded best-effort.
- Lingua principale
- Rust
- Stelle
- 1
- Fork
- 0
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apache/iotdb-client-rust
-
Session::open does not fail over when openSession/requestStatementId fails (only TCP-layer failover) Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
enhancement
Difficoltà 3/5 1-2 giorni Idoneità per principianti 65/100
apache/iotdb-client-rust#10 ·
-
enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
-
bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 68/100
Tutte le issue di apache/iotdb-client-rust
Issue simili
-
has_tail_capacity wraps and get_writable_raw_unchecked commits raw_len before the bounds check Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
stratum-mining/stratum#2404 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
Axis areas are always keyboard-focusable (Sense::drag), even with allow_axis_zoom_drag(false) Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
-
bug team:backend track:services-maintenance
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
cowprotocol/services#4950 ·