Bound the sorted-scan merge by how many files' key ranges overlap

Aperta
  • Qualcosa non va?
#71 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
15/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
rust
Ambito
backend, databases

Direzione di ricerca

Start with IcebergDataSource and StreamingMergeBuilder, then review DataFusion's split_groups_by_statistics for the overlap grouping approach. The issue says per-file column statistics on FileScanTask and an iceberg-rust revision bump are prerequisites; the maintainer is preparing that change. Done means sorted scans bound the merge by maximum file range overlap, preserve sort-key and null ordering, and safely handle missing or promoted-type bounds; this work is already underway.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

With iceberg.execution.preserve_data_ordering, #55 merges one reader per data file with every file open at once, so iceberg.execution.max_merge_files_per_partition caps the number of files. A sorted table with many small commits goes over the cap and loses its order, even when most of its files don't overlap.

The plan is to bound the merge by overlap instead of file count. IcebergDataSource would read each file's bounds and null counts for the sort columns, sort the files by their first key in output order, and put each file after the first chain whose last file ends at or before it. DataFusion's split_groups_by_statistics does the same. Each chain is read one file at a time, the chains are k-way merged, and max_merge_files applies to the number of chains, which equals the maximum overlap depth. A table whose files don't overlap then merges nothing.

Cases that need care:

  • Files are compared over every claimed sort key, not just the leading one. With a tie on the leading key, comparing only that key could put one file's rows ahead of the other's when the second key says otherwise.
  • Under NULLS FIRST a file with nulls can only start a chain, and under NULLS LAST it can only end one. A missing null count on an optional column counts as nulls.
  • Descending keys swap the bounds.
  • Truncated string bounds stay correct; they just overlap more.
  • A file with missing bounds, or a bound typed differently from the column after a type promotion, gets a chain of its own. With no bounds at all, the scan behaves exactly as after #55.
  • Listing every file at planning time also needs a cap of its own.

This needs per-file column statistics on FileScanTask, which iceberg-rust doesn't carry today. That change is apache/iceberg-rust#3422, in PR apache/iceberg-rust#3424. Once it merges, this needs a bump of the iceberg-rust rev.

Related: In https://github.com/apache/datafusion-comet/pull/5331#discussion_r3830848772, @mbutrovich proposed admitting unopened files from a priority queue ordered by min bound. That bounds open readers by the same overlap depth and opens files later, which helps LIMIT, but it needs a custom merge operator. Chains reuse StreamingMergeBuilder, so I'd start there and keep admission as a possible next step.

I'm working on this and will put up the PR here once #55 and the iceberg-rust change have merged.

Lingua principale
Rust
Stelle
30
Fork
30
Merge medio
3g 19h
PR unite (30g)
15

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/datafusion-iceberg

Tutte le issue di apache/datafusion-iceberg

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.