Answer button settings disappear in short windows

Aperta
#23,368 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
android, kotlin
Ambito
mobile, testing

Direzione di ricerca

Read the compact-window Compose test in AnkiDroid/src/test/java/com/ichi2/anki/preferences/AnswerButtonsCompactWindowTest.kt and the settings UI it exercises, starting with AnswerButtonsSettingsFragment. Run the test with its short-window qualifiers and large font scale; done means the answer button setting remains visible and can be toggled. The issue says this regression is blocked by #23321, so check that work before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Blocked by dependency

This is a known and accepted regression in the linked PR.

  • Introduced and blocked by: #23321

Assisted-by: GPT-6.1-Sol xhigh & GPT-6-Astra xhigh

Subject: Answer button settings disappear in short windows

With large system text in a short window, the fixed preview consumes the controls viewport and prevents changing settings.

---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/preferences/AnswerButtonsCompactWindowTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/preferences/AnswerButtonsCompactWindowTest.kt
new file mode 100644
index 0000000000..1e8ded3737
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/preferences/AnswerButtonsCompactWindowTest.kt
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki.preferences
+
+import androidx.compose.ui.test.assertIsDisplayed
+import androidx.compose.ui.test.click
+import androidx.compose.ui.test.junit4.v2.createEmptyComposeRule
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.performScrollTo
+import androidx.compose.ui.test.performTouchInput
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.ichi2.anki.RobolectricTest
+import com.ichi2.anki.settings.Prefs
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.Robolectric
+import org.robolectric.RuntimeEnvironment
+import org.robolectric.annotation.Config
+import kotlin.test.assertTrue
+import com.ichi2.anki.common.android.R as CommonR
+
+@RunWith(AndroidJUnit4::class)
+@Config(qualifiers = "w640dp-h220dp-land")
+class AnswerButtonsCompactWindowTest : RobolectricTest() {
+    @get:Rule
+    val composeRule = createEmptyComposeRule()
+
+    @Test
+    fun `answer button switch remains usable in a short window with large text`() {
+        RuntimeEnvironment.setFontScale(2f)
+        Prefs.isNewStudyScreenEnabled = true
+        Prefs.showAnswerButtons = false
+        val intent = PreferencesActivity.getIntent(targetContext, AnswerButtonsSettingsFragment::class)
+        val controller =
+            Robolectric
+                .buildActivity(PreferencesActivity::class.java, intent)
+                .create()
+                .start()
+                .resume()
+                .visible()
+        saveControllerForCleanup(controller)
+        advanceRobolectricLooper()
+
+        composeRule
+            .onNodeWithText(targetContext.getString(CommonR.string.show_answer_buttons))
+            .performScrollTo()
+            .assertIsDisplayed()
+            .performTouchInput { click() }
+        assertTrue(Prefs.showAnswerButtons)
+    }
+}

Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/23321#pullrequestreview-5938222063

Lingua principale
Kotlin
Stelle
12.3k
Fork
3.1k
Merge medio
1g 11h
PR unite (30g)
383

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ankidroid/Anki-Android

Tutte le issue di ankidroid/Anki-Android

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.