Saving the split view editor restores a renamed tag

Aperta
#23,219 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
android, kotlin
Ambito
database, mobile

Direzione di ricerca

Start with the regression test shown in CardBrowserTest.kt, which renames a tag while the split view editor is open and then saves a note. Trace how the editor retains and saves note tags across the activity pause and resume, using the split pane editor and tag management paths as entry points. Done means the renamed tag remains "bar" after saving the edited note; run the focused CardBrowserTest.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Needs Triage
Subject: [EXISTING] Saving the split view editor restores a renamed tag

On a tablet split view, renaming a tag in Manage tags and then saving the note in the editor pane writes the old tag back.

⚠️ This issue existed before the PR and should likely be split off into a separate issue. This PR adds a new way to trigger it from the browser's tag options.

---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt
index dded6222a3..4074346b4f 100644
--- a/AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt
@@ -92,6 +92,8 @@ import com.ichi2.anki.model.SelectableDeck
 import com.ichi2.anki.model.SortType
 import com.ichi2.anki.noteeditor.toIntent
 import com.ichi2.anki.observability.undoableOp
+import com.ichi2.anki.tags.ManageTagsViewModel
+import com.ichi2.anki.tags.TagName
 import com.ichi2.anki.scheduling.ForgetCardsDialog
 import com.ichi2.anki.servicelayer.PreferenceUpgradeService
 import com.ichi2.anki.servicelayer.PreferenceUpgradeService.PreferenceUpgrade.UpgradeBrowserColumns.Companion.LEGACY_COLUMN1_KEYS
@@ -1678,6 +1680,39 @@ class CardBrowserTest : RobolectricTest() {
         }
     }
 
+    @Test
+    fun `a tag renamed in manage tags is not restored by saving the note editor pane`() =
+        runTest {
+            val note = addBasicNote("Hello", "World").update { addTag("foo") }
+            setCardBrowserFragmented(true)
+            withSplitPaneUiAsync {
+                ensureCollectionLoadIsSynchronous()
+                val controller = startActivityControllerNormallyOpenCollectionWithIntent(CardBrowser::class.java, Intent())
+                val browser = controller.get()
+                browser.waitForSearchResults()
+                browser.viewModel.setQuery("deck:\"Default\"", forceRefresh = true)
+                advanceRobolectricLooper()
+                browser.cardBrowserFragment.openNoteEditorForCurrentlySelectedRow()
+                advanceRobolectricLooper()
+
+                // Manage tags covers the browser while the tag is renamed
+                controller.pause().stop()
+                val manageTags = ManageTagsViewModel()
+                manageTags.refreshTags().join()
+                manageTags.renameTag(requireNotNull(TagName.build("foo")), requireNotNull(TagName.build("bar"))).join()
+                assertEquals(listOf("bar"), col.getNote(note.id).tags)
+                controller.start().resume()
+                advanceRobolectricLooper()
+
+                val editor = requireNotNull(browser.fragment) { "note editor unloaded" }
+                editor.setFieldValueFromUi(0, "Hello edited")
+                editor.saveNote()
+                advanceRobolectricLooper()
+
+                assertEquals(listOf("bar"), col.getNote(note.id).tags)
+            }
+        }
+
     /**
      * see issue 15609
      */

Originally posted by @criticalAY in https://github.com/ankidroid/Anki-Android/pull/22849#pullrequestreview-5875655840

Lingua principale
Kotlin
Stelle
12.3k
Fork
3.1k
Merge medio
1g 11h
PR unite (30g)
383

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ankidroid/Anki-Android

Tutte le issue di ankidroid/Anki-Android

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.