A wildcard deck name pulls in forgotten cards from unrelated decks

Aperta
#784 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
30/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
kotlin
Ambito
mobile

Direzione di ricerca

Start with the two proposed tests in AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt, which exercise the STUDY_FORGOT custom study flow. The first checks that forgotten cards from a deck named _* stay in Default; the second checks that the positive button is enabled after unsuspending a forgotten card. The issue says it should be split into separate issues, so confirm the scope with maintainers first. Done means both bugs are reproduced by tests and the tests pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

upstream-issue

Assisted-by: GPT-6.2-Sol xhigh & GPT-6.2-Astra xhigh

Subject: [EXISTING] A wildcard deck name pulls in forgotten cards from unrelated decks

Reviewing forgotten cards in a deck named `_*` can move cards from unrelated decks into the Custom Study Session.

⚠️ This issue existed before the PR and should likely be split off into a separate issue.

---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
index d7f3bc9c7c..cc7367c5ce 100644
--- a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
@@ -165,6 +165,23 @@ class CustomStudyDialogTest : RobolectricTest() {
             }
         }
 
+    @Test
+    fun `forgotten cards stay within a deck named underscore asterisk`() =
+        runTest {
+            TimeManager.reset()
+            val forgottenCard = addBasicNote().firstCard()
+            col.sched.answerCard(forgottenCard, CardAnswer.Rating.AGAIN)
+            val sourceDeck = addDeck("_*")
+            col.setDeck(listOf(addBasicNote("Unreviewed", "Card").firstCard().id), sourceDeck)
+
+            withCustomStudyFragment(args = argumentsDisplayingSubscreen(ContextMenuOption.STUDY_FORGOT, deckId = sourceDeck)) { fragment ->
+                val dialog = fragment.requireDialog() as AlertDialog
+                if (dialog.positiveButton.isEnabled) fragment.submitSubscreenData()
+            }
+
+            assertEquals(Consts.DEFAULT_DECK_ID, col.getCard(forgottenCard.id).did, "Custom Study must keep cards from Default in Default")
+        }
+
     @Test
     fun `cancelling a defaults read prevents late deck selection`() =
         runTest {
Confirmation stays disabled after a forgotten card becomes eligible [P2]
Subject: Confirmation stays disabled after a forgotten card becomes eligible

Unsuspending the only forgotten card leaves confirmation disabled until the day range is edited.

---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
index cc7367c5ce..e4a1db3821 100644
--- a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
@@ -58,6 +58,7 @@ import com.ichi2.anki.libanki.DeckId
 import com.ichi2.anki.libanki.Note
 import com.ichi2.anki.libanki.QueueType
 import com.ichi2.anki.libanki.sched.Scheduler
+import com.ichi2.anki.observability.undoableOp
 import com.ichi2.anki.utils.ext.DIALOG_FRAGMENT_TAG
 import com.ichi2.anki.utils.ext.showDialogFragment
 import com.ichi2.testutils.AnkiFragmentScenario
@@ -182,6 +183,27 @@ class CustomStudyDialogTest : RobolectricTest() {
             assertEquals(Consts.DEFAULT_DECK_ID, col.getCard(forgottenCard.id).did, "Custom Study must keep cards from Default in Default")
         }
 
+    @Test
+    fun `forgotten cards become available when unsuspended with the dialog open`() =
+        runTest {
+            TimeManager.reset()
+            val card = addBasicNote().firstCard()
+            col.sched.answerCard(card, CardAnswer.Rating.AGAIN)
+            col.sched.suspendCards(listOf(card.id))
+
+            createHostActivity().use { controller ->
+                val fragment = CustomStudyDialog.createSubDialog(Consts.DEFAULT_DECK_ID, ContextMenuOption.STUDY_FORGOT)
+                controller.get().showDialogFragment(fragment)
+                shadowOf(Looper.getMainLooper()).idle()
+
+                undoableOp { sched.unsuspendCards(listOf(card.id)) }
+                shadowOf(Looper.getMainLooper()).idle()
+
+                val dialog = fragment.requireDialog() as AlertDialog
+                assertTrue(dialog.positiveButton.isEnabled, "Restoring a forgotten card makes the same day range eligible")
+            }
+        }
+
     @Test
     fun `cancelling a defaults read prevents late deck selection`() =
         runTest {

Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/23360#pullrequestreview-6007634151

Lingua principale
Kotlin
Stelle
93
Fork
60
Merge medio
18h 14m
PR unite (30g)
9

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ankidroid/Anki-Android-Backend

Tutte le issue di ankidroid/Anki-Android-Backend

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.