Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

feat(material/dialog): Make MatTestDialogOpener better

Aperta
#33,838 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Da chiarire
Stato di attività
Attiva
Stack tecnologico
angular, typescript
Ambito
testing

Direzione di ricerca

Start with MatTestDialogOpener and the existing dialog-opener.spec.ts, then read the referenced OverlayContainer implementation and its testing-overlay comments. Investigate how fixture querying, harness loading, and afterClosed handling currently work. Done should provide a defined, tested approach that makes dialog content queryable from the fixture and simplifies checking the closing result.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: material/dialog feature gemini-triaged needs triage
Feature Description

There's currently no supported way to render an overlay (and therefore a MatDialog) inside a component fixture during unit tests. Because overlays are attached to an OverlayContainer appended to document.body, they live outside the fixture's root element, which means:

fixture.debugElement.query(...) finds nothing inside the dialog.
Loading harnesses requires TestbedHarnessEnvironment.documentRootLoader rather than the standard fixture loader.
Asserting on dialog content requires reaching back to the document, e.g. getDebugNode(document.body) as DebugElement.

MatTestDialogOpener helps instantiate a dialog-hosted component (and removes the boilerplate of manually providing MatDialogRef + MAT_DIALOG_DATA mocks), but it doesn't address querying, and testing the close result still needs a manual async flush.

I prototyped a custom OverlayContainer that appends the container into the DOM, but it expects the fixture to be the first element in body:

import { OverlayContainer } from "@angular/cdk/overlay";
import { Injectable, Provider } from "@angular/core";

@Injectable()
export class FixtureOverlayContainer extends OverlayContainer {
    protected override _createContainer(): void {
        super._createContainer();
        document.body.children[0].appendChild(this._containerElement);

    }
}

export function provideFixtureOverlayContainer(): Provider[] {
    return [{
        provide: OverlayContainer,
        useClass: FixtureOverlayContainer
    }]
}

providing it in the test environment removes the need of documentRootLoader, the "simple" loader is enough, but querying the fixture still finds nothing. I found some comments about testing overlay plans I expect it could be useful in this case.

MatTestDialogOpener helps with creating the component, but testing the closing result still requires a manual await step, like
await firstValueFrom(fixture.componentInstance.dialogRef.afterClosed());. I found in the dialog-opener.spec.ts a setTimeout is awaited, there could be an async method baked into the MatTestDialogOpener class.

It would be really nice, if there would be a TestOverlay which creates the dialog in the fixture, so no const bodyDebug = getDebugNode(document.body) as DebugElement; is needed for querying components inside the dialog. Or at least have some methods getting the debugElement of the newly created component.

Use Case

Make testing components meant to be used inside MatDialogs more convenient, not like this

Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 1h
PR unite (30g)
84

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di angular/components

Tutte le issue di angular/components

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.