Deliver Observable read values as microtasks instead of after a timer

Aperta
  • Qualcosa non va?
#3,832 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
74/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
angular, typescript
Ambito
api

Direzione di ricerca

Start with src/zones.ts:82 and the ɵzoneWrap path described in the issue; check how schedulers.insideAngular is used by the Observable wrappers. Add or update tests for the timing behavior, including a wrapped Subject and the affected compat streams. Done means values reach subscribers in a microtask after the current task, not synchronously or after a timer.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

comp: compat comp: ssr comp: zones type: feature version: current (v17+)
Version info

Angular: 22.2

Firebase: 12.19.0

AngularFire: 22.0.0-rc.0, and main

Description

Every Observable-returning read waits one timer turn before its subscriber sees a value:

  • ɵzoneWrap pipes those reads (collectionData, docData, authState, user, objectVal, listVal, fromTask, the Remote Config get*Changes streams, 34 wrappers across the modular modules including Firestore Lite) through observeOn(schedulers.insideAngular).
  • That scheduler is built over rxjs asyncScheduler (src/zones.ts:82), which defers with setInterval, so each value reaches the subscriber one macrotask after Firebase handed it over.
  • For Firestore that is a second timer: the SDK already hands each snapshot to its callback inside a setTimeout(0).
  • The scheduler came in with #2243 (merged 2020), and the comment that PR added requires that emissions are never synchronous. rxjs's AsapScheduler, which defers with Promise.resolve().then, meets that requirement and delivers at the next microtask checkpoint, before any timer.

The compat layer is affected:

  • The AngularFireAuth streams authState, user and credential deliver through the same scheduler instance and inherit whichever timing it has.
  • AngularFireFunctions and AngularFireMessaging use it only to hand over the SDK instance before their work starts, so their results are not delivered through it.
  • Compat Database and Firestore deliver through schedulers.outsideAngular and are not part of this.
How to reproduce these conditions

On a fresh Angular 22.2 app with @angular/fire@next, wrap a Subject with the real ɵzoneWrap, subscribe, and at the moment the source emits register a setTimeout(0) and a queueMicrotask:

  • When the subscriber runs, the timer has already fired, in a zone.js app and a zoneless one, in Chrome and Firefox.
  • The real collectionData against the Firestore emulator and the compat authState against the Auth emulator behave the same way in Chrome.
  • With an AsapScheduler in place of asyncScheduler, the microtask has fired and the timer has not, in every one of those runs.
Expected behavior

A value Firebase produced is handed to the subscriber as soon as the current task finishes, without an extra timer turn.

Actual behavior

Every value waits for a setInterval callback.

Lingua principale
TypeScript
Stelle
7.8k
Fork
2.2k
Merge medio
2g 12h
PR unite (30g)
24

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di angular/angularfire

Tutte le issue di angular/angularfire

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.