refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 74/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- angular, typescript
Direzione di ricerca
Read packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-lifecycle.ts and the first relevant case in transformers/jasmine-lifecycle_spec.ts. Trace how transformDoneCallback handles done() inside nested functions, then run the focused transformer spec. Done means migrated tests still await nested asynchronous callbacks or the schematic leaves those cases unchanged with a TODO.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Command
e2e, generate
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
When a spec uses Jasmine's done callback inside an asynchronous callback — subscribe(...),
setTimeout(...), an event listener — the refactor-jasmine-vitest schematic deletes the done()
call and converts the test to a plain async function. The migrated test then resolves immediately,
before the callback ever runs, so it no longer waits for — or asserts anything about — the
asynchronous work:
// before (fails under Jasmine if the observable never emits: done timeout;
// fails if the assertion inside the callback throws)
it('emits the loaded data', (done) => {
service.getData().subscribe((data) => {
expect(data).toEqual(expected);
done();
});
});
// after migration (passes unconditionally if the emission is not synchronous)
it('emits the loaded data', async () => {
service.getData().subscribe((data) => {
expect(data).toEqual(expected);
});
});
Two guarantees are lost at once:
- The completion guarantee. In Jasmine, a test whose
doneis never called fails with a
timeout. The migrated test passes instantly, so "the event/emission never happened" bugs are no
longer caught. - Failure attribution. If the callback does fire later, an assertion failure inside it throws
outside any test. Depending on timing it surfaces as an unattributed unhandled error or not at
all (when the run ends first) — instead of failing this test.
The transformation is correct for done() at the top level of the test body and for the explicitly
handled promise forms (.then(done), .then(() => done()), .catch(done.fail)), which are
rewritten to await. The problem is only done() inside a nested function that the transformer
cannot await. The existing safety check (unhandled-done-usage) does not catch this, because
removing the nested done() counts as a handled usage.
Since Vitest has no done callback, a faithful migration for the nested case would wrap the body in
an awaited promise whose resolver takes done's place:
it('emits the loaded data', () =>
new Promise<void>((done) => {
service.getData().subscribe((data) => {
expect(data).toEqual(expected);
done();
});
}));
Alternatively, the schematic could leave the test unchanged with a TODO (like
unhandled-done-usage) whenever done is referenced inside a nested function. Happy to send a PR
for whichever direction you prefer.
Minimal Reproduction
-
ng new repro --defaults && cd repro -
Replace the body of
src/app/app.spec.ts(or any spec) with a test whose callback never fires:import { Subject } from 'rxjs'; describe('done in async callback', () => { it('fails when the data never arrives', (done) => { const data$ = new Subject<number>(); data$.subscribe(() => done()); // nothing ever emits — under Jasmine this test fails with a done timeout }); }); -
Run it with Karma/Jasmine (
ng testwith the Karma builder): the test fails after the timeout —
Async function did not complete within 5000ms. -
ng generate @schematics/angular:refactor-jasmine-vitest -
The spec becomes
it('fails when the data never arrives', async () => { data$.subscribe(() => {}); });
andng test(Vitest runner) reports it as passing.
Exception or Error
Your Environment
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI : 22.3.0-next.5
Node.js : 24.15.0
Package Manager : yarn 1.22.22
Operating System : darwin arm64
┌──────────────┬───────────────────┬───────────────────┐
│ Package │ Installed Version │ Requested Version │
├──────────────┼───────────────────┼───────────────────┤
│ @angular/cli │ 22.3.0-next.5 │ ^22.3.0-next.5 │
Anything else relevant?
packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-lifecycle.ts—
transformDoneCallback: the body visitor recurses into nested functions and replaces any
done()statement with an empty statement, then marks the testasync.- The current output is asserted by the first case in
transformers/jasmine-lifecycle_spec.ts(setTimeoutwithdone()→asyncwithdone()
removed), so I wanted to raise this before proposing a behavior change. - Not OS- or browser-specific.
- Lingua principale
- TypeScript
- Stelle
- 27k
- Fork
- 11.8k
- Merge medio
- 1g 2h
- PR unite (30g)
- 225
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di angular/angular-cli
-
`@angular/[email protected]` depends on vulnerable Vite 7.3.7 - GHSA-p4f5-76q4-ffq7 (Critical RCE)Apertaarea: @angular/build
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
angular/angular-cli#34764 ·
I maintainer di solito rispondono entro 1 giorno
-
ng add @angular/ssr fails with TypeError when an NgModule in the app module file has no bootstrap arrayForse già presa @0z5a l’ha presa oggi. Apertaarea: @schematics/angular
Difficoltà 2/5 1-3 ore Idoneità per principianti 90/100
angular/angular-cli#34761 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
angular/angular-cli#34760 ·
I maintainer di solito rispondono entro 1 giorno
-
Angular SSR can crash `AngularAppEngine` servers with a single aborted request (22.2.6 regression)Forse già presa @SkyZeroZx l’ha presa 1 giorno fa. Apertaarea: @angular/ssr
Difficoltà 4/5 3-5 giorni Idoneità per principianti 20/100
angular/angular-cli#34754 ·
I maintainer di solito rispondono entro 1 giorno
-
area: @angular/build
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
angular/angular-cli#34728 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di angular/angular-cli
Issue simili
-
status/need-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
google-gemini/gemini-cli#30384 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
P2
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 84/100
I maintainer di solito rispondono entro 1 giorno
-
bug ready-for-human
Difficoltà 2/5 1-3 ore Idoneità per principianti 60/100
LucasSantana-Dev/Lucky#3150 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue priority: low size: XS
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
vercel-labs/scriptc#3979 ·
I maintainer di solito rispondono entro 1 giorno