Server polyfills are not user-controllable: no way to opt out of `@angular/platform-server/init` or add server-only polyfills
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- angular, typescript
- Ambito
- build-system
Direzione di ricerca
Start with application-code-bundle.ts at createServerPolyfillBundleOptions and trace how options.polyfills is consumed in options.ts, execute-build.ts, dev-server/vite/index.ts, and browser-esbuild. The issue proposes a normalization step and separate browser and server lists; check the existing normalization patterns and add the server polyfills spec mentioned under “Anything else relevant?”. Done means the object form works while array form preserves current behavior, with tests covering the server bundle.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Command
build, serve
Description
@angular/build:application derives the server polyfills list entirely on its own and offers no option to change it. In createServerPolyfillBundleOptions (application-code-bundle.ts#L164-L184):
zone.js/node(orzone.jsonplatform: 'neutral') is added when the browserpolyfillslist containszone.js,@angular/localize/initis added when the browser list contains it,@angular/platform-server/initis always added.
So the browser polyfills list is fully explicit, and the server polyfills list is fully implicit. Two concrete gaps follow from that:
1. There is no opt-out of the init global patch
@angular/platform-server/init is a side-effectful module whose only job is Object.assign(globalThis, domino.impl) plus globalThis.KeyboardEvent = domino.impl.Event. The framework introduced it as something an app may import before bootstrap for code that touches DOM globals at module-evaluation time (angular/angular#40559). Most apps do not need it: platform-server runs the identical shim itself in DominoAdapter.makeCurrent() → setDomTypes() on every platform init, so for everything that runs after bootstrap the init patch is redundant and is overwritten on the first render anyway.
Since v15 the CLI adds it to every server build with no way to say no. Evidence that people need the opt-out:
- The framework's own SSR benchmarks patch
@angular/buildto strip theplatform-server/initimport frompolyfills.server.mjs(modules/ssr-benchmarks/README.mdin angular/angular), and themain.server.tsthere notes thatɵENABLE_DOM_EMULATION"won't prevent the monkey patching of DOM apis as this is introduced by the CLI". - Anyone running the server bundle outside Node with a real DOM (the benchmark case, or
ENABLE_DOM_EMULATION: false) gets Domino's classes forced ontoglobalThisregardless. - Apps that want to keep
globalThisclean on the server (noHTMLElement,Node,Event, … leaking into third-party code that feature-detects the environment withtypeof window/typeof HTMLElement) have no option either.
Measured on a default ng new --ssr app (details in #34514): the init module costs ~235 kB on disk, ~1.1 MB of retained heap for the life of the process and ~7 ms of startup, while the Object.assign itself is negligible (~7 KB, 0.03 ms). Prerendered and SSR output are byte-identical with and without it.
2. There is nowhere to put a server-only polyfill
The ssr.platform option's own description says "Please note that this feature does not provide polyfills for Node.js modules." With platform: 'neutral' (Cloudflare Workers and similar), users are expected to bring polyfills themselves, yet the only polyfills option feeds the browser bundle. Today a server-only polyfill has to be imported manually at the top of main.server.ts, where it runs after zone.js and init and after any shared chunks.
Describe the solution you'd like
Let polyfills take either the current array or a browser/server object, mirroring the existing outputPath shape (string | { base, browser, server, media }):
"polyfills": ["zone.js"] // today, unchanged
"polyfills": {
"browser": ["zone.js"],
"server": ["zone.js/node", "@angular/platform-server/init"]
}
Semantics:
- Array form keeps today's behaviour exactly:
browser= the array,server= derived as now (zone.js/node, localize,init). Non-breaking; no migration needed. - An explicit
serverlist is the server polyfills list, the same way the browser list already is: the builder adds nothing on top. To drop theinitglobal patch, omit it. To keep today's output, list it. Theng new/ssrschematics can emit the explicit form so new projects see what they get. isZonelessAppis evaluated per list (browser list for the browser bundle, server list for the server bundle), sozone.jsvszone.js/nodeand the async/await support flags fall out naturally.getEsBuildCommonPolyfillsOptionsand thepolyfills.serverbundle are unchanged; only the input list is. Normalization follows the existingnormalizeOptimization/normalizeSourceMapspattern (a smallnormalizePolyfillsinoptions.ts, folding in the string-to-array shim thatbrowser-esbuildstill relies on).- Consumers that read
options.polyfillsand would switch to.browser/.server:application-code-bundle.ts(browser bundle, server bundle,isZonelessAppchecks),execute-build.ts(top-level-await hint),dev-server/vite/index.ts(es2016target), andbrowser-esbuild's string handling.
This solves both gaps with one option and no new concept: server polyfills become as explicit as browser polyfills.
I am happy to implement this and open the PR once the shape is agreed; the single-copy fix in #34516 is independent of it and already covers the duplicate.
Describe alternatives you've considered
A boolean under ssr, next to ssr.platform, which already shapes the server polyfill list (zone.js vs zone.js/node), the createRequire banner and the xhr2 external:
"ssr": { "entry": "src/server.ts", "platform": "node", "domShims": false }
One if around line 184. It only addresses gap 1, and the name needs care so it is not confused with the framework's private ɵENABLE_DOM_EMULATION, which controls the adapter and does not affect the global shims.
Leaving it manual: users who want init could import it in main.server.ts as the v12 schematic did. That would be a breaking change for apps that rely on the implicit import, and it still leaves gap 2.
Not an alternative, but related: the same unconditional init import is also why the server build currently ships two copies of Domino (#34514). That has a bundling-level fix that does not need this option; this request is about control, not about the duplicate.
Anything else relevant?
- No spec or e2e currently asserts anything about
polyfills.server.mjs,zone.js/nodeor@angular/platform-server/init;tests/options/polyfills_spec.tsonly coversdist/browser/polyfills.js. Either solution should add a server polyfills spec. - The webpack server builder only adds
initwhen@angular/platform-serveris installed (isPackageInstalledinwebpack/configs/common.ts); the esbuild path has no equivalent guard. - Repro and measurements: https://github.com/ChristopherPHolder/ng-double-domino
- Lingua principale
- TypeScript
- Stelle
- 27k
- Fork
- 11.8k
- Merge medio
- 1g 7h
- PR unite (30g)
- 258
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di angular/angular-cli
-
area: @angular/build gemini-triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
angular/angular-cli#33955 ·
I maintainer di solito rispondono entro 1 giorno
-
area: @angular/cli gemini-triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
angular/angular-cli#33055 · 1 commento · 3 reazioni ·
I maintainer di solito rispondono entro 1 giorno
-
area: @angular/build
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
angular/angular-cli#34524 · 1 commento · 2 reazioni ·
I maintainer di solito rispondono entro 1 giorno
-
Tailwind CSS v4 classes in new or moved files are not picked up by ng serve until another rebuildForse già presa @MeAkib l’ha presa 7 giorni fa. Apertaarea: @angular/build
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
angular/angular-cli#34446 ·
I maintainer di solito rispondono entro 1 giorno
-
area: @angular/build
Difficoltà 4/5 3-5 giorni Idoneità per principianti 58/100
angular/angular-cli#34396 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di angular/angular-cli
Issue simili
-
comp/desktop desktop/shell os/windows P3 tool/file type/bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
NousResearch/hermes-agent#145928 ·
I maintainer di solito rispondono entro 1 giorno
-
compiler-dom: stringifyStatic renders :disabled="0" as a present attributeForse già presa @DaZuiZui l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
vuejs/core#16051 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 74/100
-
integration:coding-agents
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 83/100
vectorize-io/hindsight#6151 ·
I maintainer di solito rispondono entro 1 giorno
-
DogFooding
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
OpenAEV-Platform/openaev#8768 ·
I maintainer di solito rispondono entro 1 giorno