PR Approval & merge processes

Aperta
  • Qualcosa non va?
#602 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, javascript
Ambito
developer-experience

Direzione di ricerca

The issue discusses approval thresholds and waiting periods for pull requests, including exceptions for team member authored PRs and broad-impact decisions. Start by reading the discussion linked from issue 596 and the repository's existing contribution and PR guidance. Done means the team agrees on a policy and documents or implements it; the issue does not identify a code entry point or tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Ok moving this to an issue!! so then we can act on it! :)

Oh my bad, yeah I agree 👍 Sorry for merging without waiting

please don't apologize!! it's awesome that you are here. i just want to make sure people that are active see these changes :)

So a team-member-authored PR would only require one other team member approval to satisfy the 2 approval rule. PRs from non-team-members would still require two. What do y'all think about either or both of those?

I really like that for maintainer opened pr's!!

Namely, if some time period has passed (1 day, 2 days?), and there's been at least one team member approval, then it would be ok to still move forward and merge.

i'm ok with that too. except maybe if we are talking about something like a decision on pnpm or templates that impact us all maybe we provide just a bit more time. I suppose we can always make changes though for things like this.

Originally posted by @lwasser in https://github.com/all-contributors/cli/issues/596#issuecomment-6673738673

Lingua principale
JavaScript
Stelle
425
Fork
152
Merge medio
1g 6h
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di all-contributors/cli

Tutte le issue di all-contributors/cli

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.