[BUG] record.set reports a rejected value as internal: engine/transport failure

Aperta
#454 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Read aimdb-core/src/typed_record.rs around line 1524 to understand the rejected value error, then trace how map_db_err in aimdb-core/src/session/aimx/dispatch.rs maps it and how RpcError is decoded in aimdb-client/src/engine.rs and aimx/codec.rs. The issue calls for a distinct wire error code that preserves the deserialization message while keeping engine and transport failures internal. Done means rejected values produce the specific error and unknown codes still fall back as described; the issue does not name tests to run.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Describe the bug
When a remote record.set value fails to deserialize into the record's type, the client gets the same error as a broken engine or transport:

AimDB client error: Server error (code internal): engine/transport failure

The write is refused correctly and the session stays up. The problem is the report: a caller, especially an MCP agent, cannot tell that its own value was at fault, so it has no reason to correct it.

The server does build a specific message (typed_record.rs:1524), but it is lost on the way out:

  • map_db_err sends everything except not-found and permission errors to RpcError::Internal.
  • RpcError carries no message, so the client fills in its generic text (engine.rs:593).

To Reproduce

  1. Run an instance with a writable record whose type rejects some JSON, for example a custom deserializer that bounds a list's length.
  2. Call record.set (or MCP set_record) with a value that type rejects.
  3. See the error above.

Observed with a list over its bound (33 and 2000 elements against a limit of 32). A coordinate of 1e40 for an f32 field got the same reply; I did not trace that case separately.

Expected behavior
A distinct error code for a value the record's type rejected, separate from internal, ideally carrying the deserialization message. Real engine and transport failures keep internal.

Environment

  • OS: macOS 13 (Darwin 22.6)
  • Rust Version: rustc 1.98.0
  • AimDB Version: main at d9c7be0

Additional context
A new code changes the AimX wire vocabulary, so existing clients need to handle it. code_err in aimx/codec.rs currently maps unknown codes to Internal, so older clients would fall back to today's behaviour.

Lingua principale
Rust
Stelle
101
Fork
20
Merge medio
2h 33m
PR unite (30g)
90

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aimdb-dev/aimdb

Tutte le issue di aimdb-dev/aimdb

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.