Drop the embassy-sync git patch once a release carries poll_next_message / poll_changed

Aperta
  • Qualcosa non va?
#386 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
22/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
build-system, embedded-iot

Direzione di ricerca

Start with the [patch.crates-io] block in the workspace Cargo.toml and the matching dependency lines in aimdb-mqtt-connector/Cargo.toml, then check crates.io for an embassy-sync release that includes poll_next_message and poll_changed. Only after that release exists, bump the crates, remove the patch entries, and update PUBLISH_NO_VERIFY in the Makefile. Done means the workspace resolves from registry releases and the embedded build (make test-embedded) passes. The work is blocked on upstream, so confirm the release status with a maintainer first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

dependencies

Tracking issue for moving embassy-sync (and the two crates that follow it) back to crates.io releases.

Background

aimdb-embassy-adapter/src/buffer.rs polls Subscriber::poll_next_message and Receiver::poll_changed directly. Both are merged upstream but not in embassy-sync 0.8.0, still the latest on crates.io. The workspace therefore patches them in (Cargo.toml, [patch.crates-io], added in #343 for #341):

  • embassy-sync → embassy git rev 03c826f
  • embassy-net-driver-channel and embassy-net-driver → same rev. Published embassy-net-driver-channel 0.4.0 calls the pre-guard zerocopy_channel API the patched embassy-sync no longer has, and its driver trait must be the same instance embassy-net sees.

Consequences while the patch is in place:

  • Publishing: patches are not published, so the packaged aimdb-embassy-adapter cannot build its embassy-sync feature for a downstream user. The Makefile publishes it without verification (PUBLISH_NO_VERIFY) for this reason. The vendored copy carries the same 0.8.0 version as the registry release, so nothing flags the mismatch.
  • Other embassy bumps: pinning further embassy-* crates to git is constrained by this rev. E.g. pointing embassy-stm32 at 03c826f to pick up the BufferedUart TX fix fails to resolve (embassy-time-driver conflict), see #382 / #385.

To do once a release carries both APIs

  • Bump embassy-sync in the workspace Cargo.toml and in aimdb-mqtt-connector/Cargo.toml (it declares its own embassy-sync = "0.8.0").
  • Remove the three [patch.crates-io] entries and their comment; bump embassy-net-driver-channel / embassy-net-driver (or embassy-net) to releases that match the new embassy-sync.
  • Drop aimdb-embassy-adapter from PUBLISH_NO_VERIFY in the Makefile and update its comment (it still points at #242).
  • Update the comments that point at the patch (aimdb-mqtt-connector/Cargo.toml, aimdb-embassy-adapter/src/buffer.rs around the poll_* calls).
  • Check whether this unblocks #385 (embassy-stm32 with the BufferedUart fix) so both can move together.
  • Build the embedded targets (make test-embedded or equivalent) and smoke-test one Embassy demo on the NUCLEO-H563ZI.
Lingua principale
Rust
Stelle
101
Fork
20
Merge medio
2h 33m
PR unite (30g)
90

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aimdb-dev/aimdb

Tutte le issue di aimdb-dev/aimdb

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.