hlx6: Require target revision precondition for atomic version fidelity

Aperta
  • Qualcosa non va?
#325 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
12/100
Tipo di issue
Bug
Chiarezza
Da chiarire
Stato di attività
Attiva
Stack tecnologico
git, javascript
Ambito
backend, content

Direzione di ricerca

The payload names no source files, tests or entry points, so there is no obvious first file to open. The issue is a child of tracking issue #323 and depends on a separate delivery/ordering design (item 1) and on fixing project permissions. Done would mean specified revision fidelity, ordering, retry and duplicate handling, with tests for rapid and reordered edits. Confirm the design with the maintainers before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Remaining follow-up after #336

#336 shipped best-effort VERSION verification in v1.16.1: capture the immutable DA snapshot, compare target content before creating a version, and verify the returned saved version afterwards. Missing snapshots, content mismatches and unexpected locations are explicit failures with recovery evidence. Unknown mutation outcomes are not blindly retried.

Unresolved limitation

The target VERSION endpoint does not accept a caller revision precondition. A concurrent target edit between the preflight GET and VERSION POST can therefore create an incorrect historical version. Postflight verification can detect the mismatch but cannot prevent or undo it. Raw content transformations can also cause conservative verification failures.

Remaining work

  • Coordinate target API support in adobe/helix-api-service for conditional version creation tied to the revision/content verified by the caller.
  • Wire the supported precondition into DA and explicitly handle precondition failures without blindly repeating an uncertain version creation.
  • Test an edit between preflight verification and VERSION creation: no incorrect historical snapshot should be created or reported as successful.
  • Define comparison semantics for transformed HTML and retain existing diagnostic/recovery evidence.

This is a forward-looking correctness follow-up, not a request to replay historical failures. The user reported manual cleanup completed on 2026-11-05; that does not resolve this concurrency limitation. Original investigation and scope decisions remain in #323 and its history.

Lingua principale
JavaScript
Stelle
6
Fork
18
Merge medio
9h 30m
PR unite (30g)
3

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di adobe/da-admin

Tutte le issue di adobe/da-admin

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.