Runner Counts Incorrect in metrics in 0.11.0

Aperta
#4,013 1 commento 3 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
github-actions, go, helm, kubernetes

Direzione di ricerca

Inizia dalla configurazione delle metriche del listener e dai log collegati del controller e del listener, quindi confronta il comportamento dei gauge in 0.11.0 con il comportamento segnalato in 0.10.1. Riproduci la configurazione con i valori predefiniti di listenerMetrics elencati e verifica che gha_assigned_jobs, gha_busy_runners e gha_idle_runners corrispondano ai conteggi dei runner di GitHub.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug gha-runner-scale-set needs triage
Checks
Controller Version

0.11.0

Deployment Method

Helm

Checks
  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
To Reproduce
1. Enable all listenerMetrics as mentioned in the 0.11.0 [release notes](https://github.com/actions/actions-runner-controller/releases/tag/gha-runner-scale-set-0.11.0) and [related issue](https://github.com/actions/actions-runner-controller/issues/3993)
2. port-forward the metrics container port to local
3. Run some jobs and monitor metrics
Describe the bug

The gha_assigned_jobs, gha_busy_runners, and gha_idle_runners gauges never match the actual values or the values displayed inside of Github (which are correct). This issue started with upgrading to 0.11.0. The 0.10.1 values before the change to how metrics worked were correct.

With no jobs running, the gauges correctly report no assigned jobs, but 5 busy runners and 5 idle runners. The correct counts are actually 0/0/3 (3 idle runners, no busy).

# HELP gha_assigned_jobs Number of jobs assigned to this scale set.
# TYPE gha_assigned_jobs gauge
gha_assigned_jobs{name="cicd-pipelines-x2bqb"} 0
# HELP gha_busy_runners Number of registered runners running a job.
# TYPE gha_busy_runners gauge
gha_busy_runners{name="cicd-pipelines-x2bqb"} 5
# HELP gha_idle_runners Number of registered runners not running a job.
# TYPE gha_idle_runners gauge
gha_idle_runners{name="cicd-pipelines-x2bqb"} 5

Image

Describe the expected behavior

The gha_assigned_jobs, gha_busy_runners, and gha_idle_runners gauges should match the numbers visible in Github.

Additional Context
The listener metrics values in the runner scaling set. They are just the uncommented defaults.


listenerMetrics:
  counters:
    gha_started_jobs_total:
      labels:
        ["repository", "job_name", "event_name"]
    gha_completed_jobs_total:
      labels:
        [
          "repository",
          "job_name",
          "event_name",
          "job_result",
        ]
  gauges:
    gha_assigned_jobs:
      labels: ["name"]
    gha_running_jobs:
      labels: ["name"]
    gha_registered_runners:
      labels: ["name"]
    gha_busy_runners:
      labels: ["name"]
    gha_min_runners:
      labels: ["name"]
    gha_max_runners:
      labels: ["name"]
    gha_desired_runners:
      labels: ["name"]
    gha_idle_runners:
      labels: ["name"]
  histograms:
    gha_job_startup_duration_seconds:
      labels:
        ["repository", "organization", "enterprise", "job_name", "event_name"]
      buckets:
        [
          0.01,
          0.05,
          0.1,
          0.5,
          1.0,
          2.0,
          3.0,
          4.0,
          5.0,
          6.0,
          7.0,
          8.0,
          9.0,
          10.0,
          12.0,
          15.0,
          18.0,
          20.0,
          25.0,
          30.0,
          40.0,
          50.0,
          60.0,
          70.0,
          80.0,
          90.0,
          100.0,
          110.0,
          120.0,
          150.0,
          180.0,
          210.0,
          240.0,
          300.0,
          360.0,
          420.0,
          480.0,
          540.0,
          600.0,
          900.0,
          1200.0,
          1800.0,
          2400.0,
          3000.0,
          3600.0,
        ]
    gha_job_execution_duration_seconds:
      labels:
        [
          "repository",
          "organization",
          "enterprise",
          "job_name",
          "event_name",
          "job_result",
        ]
      buckets:
        [
          0.01,
          0.05,
          0.1,
          0.5,
          1.0,
          2.0,
          3.0,
          4.0,
          5.0,
          6.0,
          7.0,
          8.0,
          9.0,
          10.0,
          12.0,
          15.0,
          18.0,
          20.0,
          25.0,
          30.0,
          40.0,
          50.0,
          60.0,
          70.0,
          80.0,
          90.0,
          100.0,
          110.0,
          120.0,
          150.0,
          180.0,
          210.0,
          240.0,
          300.0,
          360.0,
          420.0,
          480.0,
          540.0,
          600.0,
          900.0,
          1200.0,
          1800.0,
          2400.0,
          3000.0,
          3600.0,
        ]
Controller Logs
Controller logs: https://gist.github.com/AngellusMortis/db74503c1c9717ad4d3dc9975b6b73ab
Runner Pod Logs
Listener logs: https://gist.github.com/AngellusMortis/66227f21bad83088e3edc9b307a8642e
Lingua principale
Go
Stelle
6.7k
Fork
1.5k
Merge medio
1h 34m
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di actions/actions-runner-controller

Tutte le issue di actions/actions-runner-controller

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.