[BUG] build_dep in pubspec.py crashes with AttributeError on path, git, or unversioned dependencies

Aperta
#5,491 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@Adnan9-63 ci sta già lavorando.

Dal 17/11/2026.

  • #5492 di @muskan-creates352 — chiusa senza merge
  • #5497 di @Adnan9-63 — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
python
Ambito
backend, databases

Direzione di ricerca

Read src/packagedcode/pubspec.py, especially build_dep and collect_deps, then reproduce with the pubspec.yaml shown in the issue. Check whether path, git, and unversioned dependencies parse without crashing and retain their dependency data. Done means the scan returns dependencies instead of an empty package list; linked pull request #5492 is already open.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem Description

In src/packagedcode/pubspec.py, the build_dep function assumes version is always a string containing a version number.

When a pubspec.yaml contains:

  1. Path dependencies (e.g. path: ../local_pkg)
  2. Git dependencies (e.g. git: https://github.com/...)
  3. Unversioned dependencies (e.g. collection: where YAML parses the value as None)

build_dep crashes with an AttributeError because it calls .replace('.', '') directly on version without verifying that it is a string.

During a scan (scancode --package), this unhandled exception causes ScanCode to fail silently on pubspec.yaml, returning 0 packages and missing all dependencies.

Steps to Reproduce
  1. Create a pubspec.yaml containing a path dependency and an unversioned dependency:
name: my_flutter_app
version: 1.0.0

dependencies:
  flutter:
    sdk: flutter
  my_local_package:
    path: ../my_local_package
  collection:
  1. Run a package scan:
scancode --package --json-pp scan.json pubspec.yaml
  1. scan.json reports packages: [] (dependencies are completely lost).

  2. Directly calling DartPubspecYamlHandler.parse reveals the traceback:

Traceback (most recent call last):
  File "src/packagedcode/pubspec.py", line 288, in build_package
    package_dependencies.extend(dependencies)
  File "src/packagedcode/pubspec.py", line 193, in collect_deps
    dep = build_dep(...)
  File "src/packagedcode/pubspec.py", line 216, in build_dep
    if version.replace('.', '').isdigit():
AttributeError: 'dict' object has no attribute 'replace'

(Or AttributeError: 'NoneType' object has no attribute 'replace' if version is None).

Root Cause

In src/packagedcode/pubspec.py, line 216:

def build_dep(name, version, scope, is_runtime=True, is_optional=False):
    if isinstance(version, dict) and 'sdk' in version:
        version = ', '.join(': '.join([k, str(v)]) for k, v in version.items())

    if version.replace('.', '').isdigit():
        purl = PackageURL(
            type='pubspec',
            name=name,
            version=version,
        )
        is_pinned = True
  • If version is None, version.replace(...) raises AttributeError: 'NoneType' object has no attribute 'replace'.
  • If version is a dict (such as {'path': '...'} or {'git': '...'}), version.replace(...) raises AttributeError: 'dict' object has no attribute 'replace'.
Expected Behavior
  • Path and git dependencies should not crash the parser; their mapping should be safely preserved in extra_data.
  • Unversioned dependencies should result in a valid DependentPackage with extracted_requirement=None and is_pinned=False.
Proposed Solution

Safely check types and extract version/extra_data in build_dep:

def build_dep(name, version, scope, is_runtime=True, is_optional=False):
    extra_data = {}
    extracted_requirement = None
    is_pinned = False

    if isinstance(version, dict):
        if 'sdk' in version:
            extracted_requirement = ', '.join(': '.join([k, str(v)]) for k, v in version.items())
        else:
            extra_data = version
            if 'version' in version and isinstance(version['version'], str):
                extracted_requirement = version['version']
    elif isinstance(version, str):
        extracted_requirement = version

    if extracted_requirement and isinstance(extracted_requirement, str) and extracted_requirement.replace('.', '').isdigit():
        purl = PackageURL(
            type='pubspec',
            name=name,
            version=extracted_requirement,
        )
        is_pinned = True
    else:
        purl = PackageURL(
            type='pubspec',
            name=name,
        )

    dep = models.DependentPackage(
        purl=purl.to_string(),
        extracted_requirement=extracted_requirement,
        scope=scope,
        is_runtime=is_runtime,
        is_optional=is_optional,
        is_pinned=is_pinned,
        extra_data=extra_data,
    )
    return dep
Environment
  • ScanCode version: 33.0.0rc1 / develop branch
  • OS: All
Lingua principale
Python
Stelle
2.7k
Fork
871
Merge medio
1g 10h
PR unite (30g)
3

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aboutcode-org/scancode-toolkit

Tutte le issue di aboutcode-org/scancode-toolkit

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.