[Bug]: v0.3 SendMessage returns Internal error instead of InvalidParams for a missing messageId or empty parts

Aperta
#1,336 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@cchinchilla-dev ci sta già lavorando.

Dal 15/11/2026.

  • #1337 di @cchinchilla-dev — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
20/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
java

Direzione di ricerca

Read Convert_v0_3_To10RequestHandler and ProtoUtils_v0_3.FromProto, focusing on the message send paths named in the issue. Compare how v1.0 converts these validation exceptions to invalid-params errors. The issue says a fix is already being opened in linked PR #1337, so check that work before taking this on.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happened?

In the v0.3 compatibility layer, a SendMessage whose message has no messageId or an empty parts list is only rejected with InvalidParamsError by JSON-RPC message/send. REST and gRPC report it as an internal error (HTTP 500 and INTERNAL), and so does JSON-RPC message/stream when messageId is missing.

Both checks throw IllegalArgumentException from a record constructor:

  • messageId: Message_v0_3 accepts a null messageId, but the v1.0 Message it is converted to in MessageSendParamsMapper_v0_3.toV10 (called from Convert_v0_3_To10RequestHandler.onMessageSend and onMessageSendStream) throws Parameter 'messageId' may not be null.
  • parts: on REST and gRPC, ProtoUtils_v0_3.FromProto.message builds a Message_v0_3, which throws Parts cannot be empty.

Only JSONRPCHandler_v0_3.onMessageSend maps that exception to InvalidParamsError_v0_3:

} catch (IllegalArgumentException t) {
    return new SendMessageResponse_v0_3(request.getId(), new InvalidParamsError_v0_3(t.getMessage()));
}

Everywhere else it reaches catch (Throwable) and is reported as InternalError_v0_3. The v1.0 side does not have this problem, because ProtoUtils.FromProto.convert() turns the same exception into InvalidParamsError where it is raised.

Against the compat-0.3/tck server on main:

$ curl -s -w ' [%{http_code}]' localhost:9999/v1/message:send -H 'Content-Type: application/json' \
    -d '{"message":{"role":"ROLE_USER","content":[{"text":"x"}]}}'
{"error": "org.a2aproject.sdk.compat03.spec.InternalError_v0_3", "message": "Internal error"} [500]

$ curl -s -w ' [%{http_code}]' localhost:9999/v1/message:send -H 'Content-Type: application/json' \
    -d '{"message":{"messageId":"m-1","role":"ROLE_USER","content":[]}}'
{"error": "org.a2aproject.sdk.compat03.spec.InternalError_v0_3", "message": "Internal error"} [500]

The v0.3 TCK reports this for REST and gRPC in the tck-test-0-3 job of the Run TCK workflow on main: test_missing_required_message_fields (Expected InvalidParams error code -32602 for missing messageId, but got: -32603) and test_empty_arrays. The JSON-RPC streaming case is not covered by the TCK.

Expected: InvalidParamsError_v0_3 on every transport, as JSON-RPC message/send returns.
Actual: InternalError_v0_3 (HTTP 500 for REST message:send, an InternalError_v0_3 event for message:stream, INTERNAL over gRPC, -32603 for JSON-RPC message/stream).

Suggested fix: convert the IllegalArgumentException to an invalid params error where it is raised, as v1.0 does: around MessageSendParamsMapper_v0_3.INSTANCE.toV10(...) in Convert_v0_3_To10RequestHandler, and in ProtoUtils_v0_3.FromProto.messageSendParams. That covers the three transports without catching unrelated exceptions in the handlers.

I have a fix ready and I'm opening a PR alongside this issue.

Code of Conduct
  • I agree to follow this project's Code of Conduct
Lingua principale
Java
Stelle
514
Fork
200
Merge medio
1g 2h
PR unite (30g)
53

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di a2aproject/a2a-java

Tutte le issue di a2aproject/a2a-java

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.