How should wasi-libc handle `POLLPRI`?

Aperta
#760 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Da chiarire
Stato di attività
Ferma
Stack tecnologico
c, wasm

Direzione di ricerca

Inizia esaminando la PR #754 e la descrizione della issue relativa alla gestione di select, pselect e poll per POLLPRI. Raccogli opinioni sul fatto che POLLPRI debba essere esportato e che poll debba ignorarlo o restituire ENOSYS; il lavoro è completato quando il progetto raggiunge e documenta una decisione chiara sul comportamento.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

In https://github.com/WebAssembly/wasi-libc/pull/754 it was discovered that there are applications, such as vim, which set the exceptfds argument to the select and pselect functions. The man pages for these functions indicate that this argument corresponds to the POLLPRI argument to the poll function. Prior to #754 wasi-libc didn't define POLLPRI as a constant and also returned an ENOSYS error if exceptfds was set for either select or pselect. In #754 this behavior has now changed where POLLPRI is defined, select and pselect thread fds to poll with POLLPRI set, and poll has some handling now. Specifically in poll it effectively ignores POLLPRI unless everything is exclusively waiting on that event in which case ENOSYS is returned.

I'm opening this issue to have some further discussion of this and see if anyone else has thoughts on this as well. Specific questions I would have are:

  • Is anyone opposed to exposing POLLPRI in wasi-libc? Personally I feel this is justified because we already can't statically rule out setting exceptfds arguments in select and pselect. We've also found additionally over time that it's easier to provide constants/functions than to not provide them at all and ask applications to work around the lack of posix/unix/etc functionality. (at least in some cases, not necessarily all). Nevertheless I wanted to pose the question here: does anyone feel strongly that POLLPRI should not be exported by wasi-libc?

  • Regardless of whether POLLPRI is publicly exported or not, what should the behavior of exceptfds be with select and pselect? I still frame this in my head as POLLPRI since select and pselect are effectively just poll in a different veneer personally. In my opinion we should interpret POLLPRI as effectively an event that never happens right now in wasi-libc since it's not hooked up to anything. The man page for POLLPRI says it's for things like TCP out-of-band data and some ioctl/tty things I don't know about, but nevertheless WASI has no concept of either of these. Given that I'd personally say that we should consider this as an event that basically never fires.

  • If others agree with me that we should interpret POLLPRI as an event that never fires (yet, there's an orthogonal open question of whether WASI should provide functionality to support this), then do others disagree with changing the behavior of poll? I'd say that poll should probably just ignore POLLPRI entirely and it turns into a glorified version of sleep if you happen to wait exclusively on things with POLLPRI. Otherwise if you wait on a mixture of POLLPRI and other things it's just as-if the POLLPRI thing never fired.

cc @paralin as the author of #754, and cc @sunfishcode as you might have thoughts on API-side of things here too.

Lingua principale
C
Stelle
1k
Fork
268
Merge medio
1g 3h
PR unite (30g)
20

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di WebAssembly/wasi-libc

Tutte le issue di WebAssembly/wasi-libc

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.