[Bug] UnitspecificSounds block doesn't have diagnostics
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Tranquilla
- Stack tecnologico
- rust, vscode
- Ambito
- developer-experience, tooling
Direzione di ricerca
Start by locating the schema handling for UnitSpecificSounds and DialogEvents in the ZeroSyntax language server, then compare it with the listed module sources such as CommandXlat.cpp and SpecialAbilityUpdate.cpp. Use the minimal INI sample to check how the fields are parsed. Done means the listed sound fields provide diagnostics and autocompletions without requiring users to define unused fields.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happened?
Certain modules in an object can expose additional sound fields the object can attempt to call. Typically these fields are defined within the UnitSpecificSounds block, but it seems to be just in the Object scope.
Expected behavior
The fields inside the UnitSpecificSounds should be parsed in the schema and have diagnostics and autocompletions for the DialogEvents. Additionally I think some hints on the modules which provide additional sound fields would be a great way to show this to the user. It shouldn't be enforced as the user might not want to use the field. The alternative to this would be forcing the user to set the fields to NoSound, which I don't see being friendly.
List of UnitSpecificSounds found so far:
| Module / Source | Categoty | Sound Key(s) |
|---|---|---|
| CommandXlat.cpp | GameClient / Commands Translator | VoiceSupply, VoiceUnload, VoiceRepair, VoicePickup, VoiceCombatDrop, VoiceGetHealed, VoiceEnterHostile, VoiceGarrison, VoiceEnter, VoiceCrush, VoiceSalvage, VoiceMoveUpgraded, VoiceBuildResponse, VoicePrimaryWeaponMode, VoiceSecondaryWeaponMode, VoiceTertiaryWeaponMode, VoiceBombard, VoiceClearBuilding, VoiceSubdue, VoiceDisarm, VoiceSnipePilot, VoiceMelee, VoiceFlameLocation, VoicePoisonLocation, VoiceFireRocketPods, VoiceHackInternet |
| PlaceEventTranslator.cpp | GameClient / Placement | VoiceNoBuild |
| BuildAssistant.cpp | Common / Build system | VoiceCreated |
| ProductionUpdate.cpp | Update module | VoiceCreate |
| StickyBombUpdate.cpp | Update module | StickyBombCreated, UnitBombPing |
| StealthUpdate.cpp | Update module | DisguiseStarted, DisguiseRevealedSuccess, DisguiseRevealedFailure |
| SpectreGunshipUpdate.cpp | Update module | Afterburner, HowitzerFire |
| SpecialAbilityUpdate.cpp | Update module | VoiceCaptureBuildingComplete, VoiceDisableVehicleComplete, VoiceStealCashComplete |
| DeliveryPayloadAIUpdate.cpp | AIUpdate module | StartDive |
| JetAIUpdate.cpp | AIUpdate module | VoiceLowFuel, Afterburner |
| HackInternetAIUpdate.cpp | AIUpdate module | UnitUnpack, UnitPack, UnitCashPing |
| DozerAIUpdate.cpp | AIUpdate module | UnderConstruction |
| DeplayStyleAIUpdate | AIUpdate module | Deploy, Undeploy |
| FiringTracker.cpp | Object helper | VoiceRapidFire |
| EjectPilotDie.cpp | Die module | VoiceEject, SoundEject |
| TurretAI.cpp | AI Helper | TurretMoveLoop |
Requires more attention to find the specifics, as it seems some SpecialPowers introduces some of the fields and not nessearly the module itself, but the specialpower used in the module.
Minimal INI sample
UnitSpecificSounds
VoiceCreate = BlackLotusVoiceCreate
VoiceGarrison = BlackLotusVoiceMove
VoiceEnter = BlackLotusVoiceMove
VoiceEnterHostile = BlackLotusVoiceMove
VoiceStealCashComplete = BlackLotusVoiceCashComplete
VoiceDisableVehicleComplete = BlackLotusVoiceDisableComplete
VoiceCaptureBuildingComplete = BlackLotusVoiceCaptureComplete
VoiceGetHealed = BlackLotusVoiceMove
End
Behavior = SpecialAbility ModuleTag_08
SpecialPowerTemplate = SpecialAbilityBlackLotusCaptureBuilding
UpdateModuleStartsAttack = YES
InitiateSound = BlackLotusVoiceHackBuilding
End
Behavior = SpecialAbilityUpdate ModuleTag_09
SpecialPowerTemplate = SpecialAbilityBlackLotusCaptureBuilding
StartAbilityRange = 150.0
PreparationTime = 6000 ; the time to complete the hack once prepared (unpacked)
SpecialObject = BinaryDataStream
UnpackTime = 6730 ; animation time is 6730 (changing this will scale anim speed)
PackTime = 2800 ; animation time is 5800 (changing this will scale anim speed)
DoCaptureFX = YES
PackSound = BlackLotusPack
UnpackSound = BlackLotusUnpack
TriggerSound = BlackLotusTrigger
PrepSoundLoop = BlackLotusPrepLoop
AwardXPForTriggering = 20
; SkillPointsForTriggering = ??? ; Dustin, fill me out if you want different balance values.
End
Behavior = SpecialAbility ModuleTag_10
SpecialPowerTemplate = SpecialAbilityBlackLotusDisableVehicleHack
UpdateModuleStartsAttack = YES
InitiateSound = BlackLotusVoiceHackVehicle
End
Behavior = SpecialAbilityUpdate ModuleTag_11
SpecialPowerTemplate = SpecialAbilityBlackLotusDisableVehicleHack
StartAbilityRange = 150.0
PreparationTime = 2000 ; the time to complete the hack once prepared (unpacked)
EffectDuration = 15000 ; duration the vehicle is disabled
DisableFXParticleSystem = DisabledEffectBinaryShower0
SpecialObject = BinaryDataStream
UnpackTime = 2000 ; animation time is 6730 (changing this will scale anim speed)
PackTime = 1000 ; animation time is 5800 (changing this will scale anim speed)
PackSound = BlackLotusPack
UnpackSound = BlackLotusUnpack
TriggerSound = BlackLotusTrigger
PrepSoundLoop = BlackLotusPrepLoop
AwardXPForTriggering = 0
; SkillPointsForTriggering = ??? ; Dustin, fill me out if you want different balance values.
End
Behavior = SpecialAbility ModuleTag_12
SpecialPowerTemplate = SpecialAbilityBlackLotusStealCashHack
UpdateModuleStartsAttack = YES
InitiateSound = BlackLotusVoiceHackCash
End
Behavior = SpecialAbilityUpdate ModuleTag_13
SpecialPowerTemplate = SpecialAbilityBlackLotusStealCashHack
StartAbilityRange = 150.0
PreparationTime = 6000 ; the time to complete the hack once prepared (unpacked)
EffectValue = 1000 ; amount of cash stolen
SpecialObject = BinaryDataStream
UnpackTime = 6730 ; animation time is 6730 (changing this will scale anim speed)
PackTime = 5800 ; animation time is 5800 (changing this will scale anim speed)
PackSound = BlackLotusPack
UnpackSound = BlackLotusUnpack
TriggerSound = BlackLotusTrigger
PrepSoundLoop = BlackLotusPrepLoop
AwardXPForTriggering = 20
; SkillPointsForTriggering = ??? ; Dustin, fill me out if you want different balance values.
End
Environment
- OS: Windows 11
- Editor: Vscode
- ZeroSyntax version: 1.0.3
- Lingua principale
- Rust
- Stelle
- 1
- Fork
- 0
- Merge medio
- 21h 13m
- PR unite (30g)
- 28
Preparare l'ambiente
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di ViTeXFTW/ZeroSyntaxV2
-
feature
Difficoltà 3/5 1-2 giorni Idoneità per principianti 64/100
ViTeXFTW/ZeroSyntaxV2#129 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
feature
Difficoltà 4/5 3-5 giorni Idoneità per principianti 42/100
ViTeXFTW/ZeroSyntaxV2#128 ·
I maintainer di solito rispondono entro 1 giorno
-
feature
Difficoltà 4/5 3-5 giorni Idoneità per principianti 50/100
ViTeXFTW/ZeroSyntaxV2#106 ·
I maintainer di solito rispondono entro 1 giorno
-
feature
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
ViTeXFTW/ZeroSyntaxV2#104 ·
I maintainer di solito rispondono entro 1 giorno
-
feature
Difficoltà 4/5 3-5 giorni Idoneità per principianti 50/100
ViTeXFTW/ZeroSyntaxV2#103 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di ViTeXFTW/ZeroSyntaxV2
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
trailofbits/dylint#2107 ·
I maintainer di solito rispondono entro 1 giorno
-
area:cli bug good first issue priority:medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 90/100
rtk-ai/rtk#4289 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
arrays_zip with two same-named inputs fails with "ArrowArray struct has 2 children (expected 1)"Apertabug requires-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
apache/datafusion-comet#6251 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
bug false-positive harper-core linting
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
Automattic/harper#4471 ·
I maintainer di solito rispondono entro 1 giorno