steam-short-session-tracker: incorrect registry backup path resets settings during automatic repair

Il bug si trova nello script /usr/lib/steamos/steam-short-session-tracker. Esamina le righe intorno al percorso di backup del registro. La correzione consiste nel cambiare la variabile registry_backup_vdf da $steam_config_backup_dir/.steam/registry.vdf a $steam_config_backup_dir/registry.vdf. Testa la correzione eseguendo lo script di riproduzione fornito in una directory temporanea per verificare che la copia abbia successo dopo la modifica.

steam-short-session-tracker: incorrect registry backup path resets settings during automatic repair

Your system information

• Hardware: Valve Steam Machine (DMI product name: Fremont), AMD Radeon Graphics / NAVI33
• Steam client build: 1788652215 (stable update manifest observed during recovery)
• SteamOS version: 3.8.16, build 20260716.1
• Kernel: 6.16.12-valve24.5-1-neptune-616-gb2f7cfe85e45
• Package owning the affected script: gamescope 3.16.23.4-1
• Opted into Steam client beta?: No; stable manifest observed
• Opted into SteamOS beta?: Stable default branch reported by the installed OS; UI selection not independently checked
• Have you checked for updates in Settings > System?: No, not during this investigation

Please describe your issue in as much detail as possible

The automatic repair in /usr/lib/steamos/steam-short-session-tracker tries to preserve ~/.steam/registry.vdf, but constructs the backup source path with an extra .steam/ directory. After repair, the original registry file remains in the backup but is not copied into the newly created ~/.steam. In this case, Steam and Counter-Strike 2 changed from Traditional Chinese to English.

Expected: Automatic repair preserves the existing registry/settings, as the script's own comment intends.

Actual: The copy fails with cannot stat, is ignored through || true, and Steam starts with newly generated defaults.

The installed script contains:

steam_config_dir="$HOME/.steam"
steam_config_backup_dir="$HOME/dot-steam.bak.$(date +%s)"
registry_vdf="$steam_config_dir/registry.vdf"
registry_backup_vdf="$steam_config_backup_dir/.steam/registry.vdf"
mv "$steam_config_dir" "$steam_config_backup_dir"
mkdir -p "$steam_config_dir"
cp -f "$registry_backup_vdf" "$registry_vdf" || true

Because mv renames ~/.steam to the previously nonexistent backup directory, the actual file is $steam_config_backup_dir/registry.vdf, not $steam_config_backup_dir/.steam/registry.vdf.

Observed logs and impact

Journal excerpts (hostname and backup timestamp omitted):

steam-short-session-tracker: Steam failed to start 3 times within 60 seconds
steam-short-session-tracker: Re-bootstrapping steam from OS copy.
cp: cannot stat '/home/deck/dot-steam.bak.<timestamp>/.steam/registry.vdf': No such file or directory

The real backup file was found one directory higher and still contained the original tchinese language settings. Restoring that file while Steam was stopped, then restarting Steam and CS2, restored Traditional Chinese. The Steam web helper returned to -lang=zh_TW, and the game menu was visually verified.

Context only: the repair loop followed a Gamescope crash triggered by a diagnostic gamescopectl backend_info invocation. The HDMI-connected TV was off, both DRM connectors reported disconnected, and subsequent DRM-session starts failed with cannot find any connected connector!. A headless session restored operation. This issue is specifically about the independently reproducible registry backup path error, not a claim about the crash's low-level cause or Remote Play resolution negotiation.

Steps for reproducing this issue

The path error can be reproduced without running the repair script or touching an actual Steam installation:

(
  set -eu
  repro_dir=$(mktemp -d)
  trap 'rm -rf -- "$repro_dir"' EXIT

  mkdir "$repro_dir/.steam"
  printf '%s\n' 'test fixture' > "$repro_dir/.steam/registry.vdf"

  steam_config_dir="$repro_dir/.steam"
  steam_config_backup_dir="$repro_dir/dot-steam.bak.test"
  registry_backup_vdf="$steam_config_backup_dir/.steam/registry.vdf"

  mv "$steam_config_dir" "$steam_config_backup_dir"
  mkdir -p "$steam_config_dir"

  test -f "$steam_config_backup_dir/registry.vdf"
  test ! -e "$registry_backup_vdf"
  cp -f "$registry_backup_vdf" "$steam_config_dir/registry.vdf"
)

The final copy fails, although the backup file exists. The same move/path behavior was independently verified in an isolated temporary directory during this investigation.

Suggested correction

-registry_backup_vdf="$steam_config_backup_dir/.steam/registry.vdf"
+registry_backup_vdf="$steam_config_backup_dir/registry.vdf"

It may also be useful to distinguish a missing original registry from a failed restoration of an existing one, rather than silently continuing in both cases.

Related: https://github.com/ValveSoftware/steam-for-linux/issues/12035 describes short-session re-bootstrap triggers; this report isolates the incorrect registry restoration path and its observed settings loss.