Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Review longstanding trial setup-fee totals and payment timing

Aperta
  • Qualcosa non va?
#1,892 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
php, wordpress
Ambito
payments

Direzione di ricerca

Start by reviewing views/checkout/templates/order-summary/simple.php:206-238, inc/checkout/class-cart.php, and the existing Cart and gateway tests, comparing main with v2.16.1. Done means the intended timing and displayed initial/recurring amounts are documented, the billing cases are checked, and any implementation is separately scoped after the maintainer records a decision.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

hold-for-review no-auto-dispatch origin:interactive status:available type:bug

Review-only follow-up

Requested by the maintainer during release smoke testing. Do not change trial charging or display behavior automatically: the intended timing of setup fees must be reviewed first. This is a durable manual review hold, not an implementation/auto-dispatch request.

Observation

With a $19.99/month plan, a trial, and a $9.99 one-time setup fee:

  • the order summary lists the fee but shows $0 as Today's Grand Total
  • it shows $29.98 at the end of the trial
  • the current Cart has a non-recurring $9.99 fee and should_collect_payment() returns true

This needs review for consistency with the intended billing contract, not an assumption that the display recently regressed.

History checked

  • git log --follow -S 'wu_format_money(0)' -- views/checkout/templates/order-summary/simple.php traces the zero-total branch to initial repository commit e8f7955c (2024-11-30).
  • Formatting commit 8433379d (2025-02-07) retains it.
  • The same branch is present in tag v2.16.1.
  • The newer fee-collection logic, including the restored-trial change in #1878, must be considered separately from this longstanding display rule.

Verified files / reference patterns

  • views/checkout/templates/order-summary/simple.php:206-238: unconditional zero displayed whenever order.has_trial, then order.totals.total displayed for trial-end billing.
  • inc/checkout/class-cart.php: should_collect_payment() and initial/non-recurring versus recurring totals.
  • tests/unit/Cart_Should_Collect_Payment_Test.php: existing restored-trial and non-recurring-fee regressions.
  • inc/gateways/class-paypal-gateway.php: existing initial/recurring amount and discount scoping.

Review deliverables

  1. Establish whether setup fees are intended to be charged immediately, deferred, or configurable during a trial.
  2. Compare current main with v2.16.1 for actual initial-charge behavior, not just display text.
  3. Check new and restored checkout, no-card trials on/off, one-time fees, discounts and taxes.
  4. Document which initial and recurring amounts the summary should present under the chosen contract.
  5. If a change is warranted, scope a separate implementation with compatibility notes; do not silently change existing customer billing timing.

Verification for any later implementation

Use the existing Cart and gateway tests, browser order-state versus displayed totals, and sandbox initial/renewal charges. No new test infrastructure is required. Live billing evidence is not yet available from the smoke-test environment.

Hold reason

no-auto-dispatch: explicit maintainer review request and unresolved billing-semantics decision. Keep this issue in review until that decision is recorded.

aidevops.sh v3.34.13 plugin for OpenCode v1.18.31 with gpt-6.1-sol spent 2h 22m and 418,760 tokens on this with the user in an interactive session.

Lingua principale
PHP
Stelle
214
Fork
86
Merge medio
13h 15m
PR unite (30g)
59

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ultimate-Multisite/ultimate-multisite

Tutte le issue di Ultimate-Multisite/ultimate-multisite

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.