[svelte] createTableHook: App* wrappers call setContext in the parent's component context (set_context_after_init when showing a column)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 68/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
- Ambito
- frontend
Direzione di ricerca
Start by reading createTableHook.svelte.js and the AppCell.svelte, AppHeader.svelte, and AppTable.svelte components named in the issue; check how the wrappers and components set context. Reproduce the error in the linked Svelte playground by showing the hidden Age column. Done means newly created cells, headers, and tables set context in their own component initialization, and toggling the column no longer errors.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
TanStack Table version
@tanstack/svelte-table v9.2.5 (the same code is in v9.2.6)
Framework/Library version
Svelte v5.57.1, with compilerOptions.experimental.async: true
Describe the bug and the steps to reproduce it
With createTableHook, any <table.AppCell> / <table.AppHeader> that is created after the component using it has initialized throws set_context_after_init, and the cells don't render. The most common trigger is showing a hidden column; it also affects anything else that creates new cells later.
Svelte error: set_context_after_init
`setContext` must be called when a component first initializes, not in a subsequent effect or after an `await` expression
at setContext
at AppCell (createTableHook.svelte.js)
Steps (see the playground below):
- Create a table with
createTableHook/createAppTablewhere one column is hidden (initialState: { columnVisibility: { age: false } }), and render cells with<table.AppCell {cell}>. - Show the column:
table.getColumn('age').toggleVisibility(). - The error is thrown and the new column's cells aren't rendered.
Cause: createAppTable builds the App* wrappers as plain functions that call setContext and then call the real component:
const AppCell = ((internal, { children, cell }) => {
setContext(cellContextKey, cell);
return AppCellSvelte(internal, { cell, cellComponents: cellComponentsWithFlexRender, children });
});
setContext runs before AppCellSvelte has pushed its own component context, so it writes into the parent's context (the component that renders <table.AppCell>). Svelte's async mode validates that setContext only runs while a component initializes. That holds during the parent's first render, but not for cells created later, e.g. when a column is shown. Without async mode it doesn't throw, but cells/headers still get written into the parent's context map rather than their own. The same applies to AppHeader, AppFooter and AppTable.
Possible fix, which I'm using as a local patch: let the App*Svelte components set the context themselves, during their own initialization, and have the wrappers only pass props:
// createTableHook.svelte.js
- const AppCell = ((internal, { children, cell }) => {
- setContext(cellContextKey, cell);
- return AppCellSvelte(internal, {
- cell,
- cellComponents: cellComponentsWithFlexRender,
- children,
- });
- });
+ const AppCell = ((internal, { children, cell }) => AppCellSvelte(internal, {
+ cell,
+ cellComponents: cellComponentsWithFlexRender,
+ contextKey: cellContextKey,
+ children,
+ }));
<!-- AppCell.svelte -->
<script lang="ts">
- import type { Snippet } from 'svelte'
+ import { setContext, type Snippet } from 'svelte'
...
- let { children, cell, cellComponents }: Props = $props()
+ let { children, cell, cellComponents, contextKey }: Props = $props()
+
+ setContext(contextKey, cell)
</script>
…and the same for AppHeader / AppFooter (AppHeader.svelte) and AppTable (AppTable.svelte, which would receive table as a prop). With that patch, showing/hiding columns, paging, sorting and filtering work without errors, and useCellContext / useHeaderContext / useTableContext return the right instances.
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
Click Toggle "Age": the error appears in the console and the "Age" cells don't render.
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
Yes, I think I know how to fix it and will discuss it in the comments of this issue
Terms & Code of Conduct
- I agree to follow this project's Code of Conduct
- I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
- Lingua principale
- TypeScript
- Stelle
- 28.5k
- Fork
- 3.6k
- Merge medio
- 19h 40m
- PR unite (30g)
- 8
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TanStack/table
-
Issue template renders `react-table`, not `TanStack/table`Forse già presa @vishruthasgowda l’ha presa 14 giorni fa. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
TanStack/table#6595 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 38/100
TanStack/table#6601 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Cast required to access custom options when defining a custom plugin/featureForse già presa @sorena-paydar l’ha presa 15 giorni fa. Aperta
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
`aggregatedCell` not typed against bound `cellComponents` in `createAppColumnHelper`Forse già presa @cpruijsen l’ha presa 26 giorni fa. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
TanStack/table#6577 · 6 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TanStack/table
Issue simili
-
check:passed streams:add
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
OpenSlides/OpenSlides#7180 ·
-
area:claude-code-web area:docs bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
anthropics/claude-code#100184 ·
I maintainer di solito rispondono entro 1 giorno
-
Thumbnail generation from video buffers frames at source resolution: 2–3 GB per upload for 4K+ HEVCAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
Chocobozzz/PeerTube#7817 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
open-telemetry/opentelemetry-js-contrib#3808 ·
I maintainer di solito rispondono entro 2 giorni