Start: prerender.concurrency does not parallelize CPU-bound page rendering

Aperta
#8,483 0 commenti 3 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
node.js, typescript, vite

Direzione di ricerca

The issue is in start-plugin-core/src/vite/prerender.ts in the startPreviewServer function. Examine how the prerender queue is processed and how the preview server is invoked. Look at the linked issue #8430 which moves prerender preview into a Node worker, as a potential starting point for parallelization. The reproducer repository includes a benchmark to test changes. 'Done' means prerendering CPU-bound pages scales with the concurrency setting across multiple cores.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Which project does this relate to?

Start

Describe the bug

prerender.concurrency suggests pages are rendered in parallel, but prerendering sends every page to one preview server (startPreviewServer in start-plugin-core/src/vite/prerender.ts). That server runs SSR in a single JavaScript thread, so concurrency only overlaps I/O waits; the rendering work of each page still happens one page at a time. For sites with many CPU-bound pages, build time grows linearly with page count, and raising concurrency changes nothing.

This isn't adapter-specific. The reproducer uses plain Start with the default Node preview server. With @cloudflare/vite-plugin the preview is one workerd process running one isolate, so the effect is the same.

Real-world impact: in a production app with ~19k prerendered pages (CPU-bound renders from bundled static data, no network I/O), prerendering takes ~110–150s locally at concurrency 1, 2 or 4 alike. In CI (Cloudflare Workers Builds, 4 vCPU) the full build went from ~1 min to ~5 min once all pages were prerendered.

As an experiment I split the same pages across 4 separate preview processes (N workerd instances started against the built dist/server). The output matched the built-in prerenderer's, except for the dehydration timestamp, and prerendering dropped to ~45s, scaling with process count (1 → 2 → 4) up to the machine's performance cores. I'd rather not maintain that workaround, since it depends on internals and unstable APIs, so an official option would be great.

Complete minimal reproducer

https://github.com/R4ULtv/tanstack-start-prerender-concurrency

Steps to Reproduce the Bug
  1. git clone https://github.com/R4ULtv/tanstack-start-prerender-concurrency && cd tanstack-start-prerender-concurrency
  2. npm install
  3. npm run bench. This runs vite build with prerender.concurrency set to 1, 4 and the machine's core count, and prints the time of each build. The app has one route, /page/$id, whose loader does ~15 ms of synchronous CPU work, with 1,000 pages prerendered (PAGE_COUNT to change).

Result on an Apple M-series Mac (10 logical cores, Node 24):

concurrency build time
1 21.3s
4 20.4s
10 19.6s
Expected behavior

With concurrency > 1 on a multi-core machine, prerendering CPU-bound pages should get faster. For example:

  • an option such as prerender.workers: number that starts N preview servers (worker threads or child processes) and spreads the page queue across them; or, at least,
  • documentation stating that concurrency only overlaps I/O and doesn't parallelize rendering.
Screenshots or Videos

No response

Platform
  • Router / Start Version: @tanstack/react-start 1.168.57, @tanstack/react-router 1.170.38
  • OS: macOS 15 (Darwin 24.6.0), Apple M-series (4 performance + 6 efficiency cores)
  • Browser: N/A (build-time issue)
  • Browser Version: N/A
  • Bundler: vite
  • Bundler Version: 8.3.0
Additional context
  • #8430 moves the prerender preview into a Node worker, which may be a natural place to start several workers.
  • Each page is requested with a trailing slash first (/page/X/ → 307 → /page/X), which doubles the number of requests during prerendering. Possibly related to #7070 / #6978.
  • With @cloudflare/vite-plugin, several local workerd instances started side by side hit SQLITE_BUSY on the shared .wrangler/state until persistence was disabled per instance. That may need coordinating with the Cloudflare plugin if several preview servers are started.
Lingua principale
TypeScript
Stelle
15.3k
Fork
1.9k
Merge medio
1g 5h
PR unite (30g)
46

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/router

Tutte le issue di TanStack/router

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.