Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

useMutation invokes the next mutation's onSettled with the previous result

Aperta
  • Qualcosa non va?
#11,451 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, typescript
Ambito
api, frontend

Direzione di ricerca

Inizia in packages/query-core/src/mutationObserver.ts intorno a MutationObserver.#notify (righe 240-293) e riproduci gli scenari di mutazioni annidate dal CodeSandbox collegato. Verifica che la callback onSettled della seconda mutazione venga eseguita solo con il proprio risultato, errore e variabili, anche quando la seconda chiamata omette options e quando la sua promise rimane pending.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe the bug

When a per-call onSuccess or onError callback starts another mutation using the same useMutation instance, the second mutation's onSettled callback receives the first mutation's result and variables. It runs again with its own result when the second mutation finishes.

The reproduction logs only the callback registered for the second mutation:

[
  { "data": "result-1", "error": null, "variables": 1 },
  { "data": "result-2", "error": null, "variables": 2 }
]
Your minimal, reproducible example

https://yjdm6m.csb.app/ https://codesandbox.io/s/yjdm6m

Steps to reproduce
  1. Open the reproduction and click 1. Start second mutation in onSuccess.
  2. Observe that the second mutation's callback receives both result-1 / variables 1 and result-2 / variables 2.
  3. Click 2. Start second mutation in onError. The second mutation's callback similarly receives the first mutation's error and variables before receiving its own successful result.
  4. As a control, click 3. Sequential calls outside callbacks. This correctly logs only the second mutation's result once.
  5. Repeat with StrictMode enabled using the link at the bottom. The behavior is the same.
Expected behavior

The second mutation's onSettled callback should run only after that mutation settles, with its own data, error, and variables:

[
  { "data": "result-2", "error": null, "variables": 2 }
]

This is not a request to invoke per-call callbacks for every consecutive mutation. The issue is that the latest mutation's callback receives a different mutation's result.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform
  • macOS 26.5
  • Chromium 150.0.0.0, as reported by the browser's user agent
  • React / React DOM 19.2.1
  • Reproduces with StrictMode both enabled and disabled
Tanstack Query adapter

react-query

TanStack Query version

@tanstack/[email protected] and @tanstack/[email protected]

TypeScript version

No response

Additional context

In additional local checks, the second mutation was held pending using a manually resolved Promise. Its onSettled callback still received the first mutation's result before the second mutation finished.

Omitting the second call's optional options argument also produces an internal TypeError, even though the user callback does not throw:

mutation.mutate(1, {
  onSuccess: () => {
    mutation.mutate(2)
  },
})

TypeError: Cannot read properties of undefined (reading 'onSettled')

In MutationObserver.#notify, this.#mutateOptions.onSettled is read after invoking onSuccess or onError. The nested mutate call replaces #mutateOptions, while the action's result and variables still belong to the first mutation.

The pending-Promise and omitted-options cases were checked separately locally; the shared sandbox contains the three button scenarios described above.

Codex assisted with preparing and verifying the reproduction.

Lingua principale
TypeScript
Stelle
50.4k
Fork
4.2k
Merge medio
22h 57m
PR unite (30g)
255

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/query

Tutte le issue di TanStack/query

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.