Gap CLI: a partial or daemon run can draw other drawn bases than a cold run without --seed

Aperta
#155 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, node.js
Ambito
testing

Direzione di ricerca

Start with src/oracle-config.ts and oracle-gaps/capture-setup.mjs, then find the gap CLI paths for cold, partial, and daemon checks. First reproduce the mismatch with a property whose history has drawnBases and no --seed; the issue says the repository’s current gap e2e and self-oracles do not provide a suitable witness. Done means a gap report establishes whether the drawn bases differ and, if they do, the CLI produces order independent bases.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

In the gap CLI, a property's drawn bases (#122, histories.drawnBases) can differ between a cold whole-file run and a partial or daemon run, when the CLI runs with no --seed. Found by reading (review of #122, round 2, G6). It is not reproduced yet.

  • Where R comes from: a fixed-seed constructed unit draws its drawn bases from R + k. R is the run's random seed: the first unit that uses it draws it from Math.random, through oracleCampaignSeed (src/oracle-config.ts).
  • The capture: it seeds Math.random per test, by the test's key (oracle-gaps/capture-setup.mjs, installRandom). So R is a function of which test is the first to call runSeed in that process.
  • The failure: in a cold whole-file run, that is the property's first drawing fixed-seed unit. If a partial run, a daemon check, or a batch copy runs a set of tests whose first drawing unit is a different one, it draws another R. A later unit's drawn bases then differ from the baseline's. Then:
    • unchanged code can read as changed (a false kill, or not-judged);
    • a verdict on a drawn base can be credited on the fixed seed route (a reproducible route, P3, G2, I8) when a cold run doesn't repeat it.
  • Not affected: with --seed, ${envPrefix}_SEED fixes R in every run, and the drawn bases are the same.
  • In this repository today: the gap e2e oracle and the self-oracle draw bases (1 each, and the e2e oracle draws none on win32). No oracle that the gap CLI judges in CI draws bases.

Ask, oracle-first:

  1. A gap-report witness: a property with drawnBases, judged cold and through the daemon (or partially) with no --seed. It should show whether the classes match.
  2. If they differ, a fix that makes R independent of test order inside the CLI. For example, the CLI could always set ${envPrefix}_SEED for a check, choosing and printing one when --seed is absent. Or it could seed oracleCampaignSeed's draw from the property id rather than from the first test's key.

This issue was written by Isaac.

Lingua principale
JavaScript
Stelle
5
Fork
1
Merge medio
11h 18m
PR unite (30g)
66

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/oracles

Tutte le issue di TanStack/oracles

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.