[v2] solid-form 2.0.0-alpha.1 cannot be imported under Solid 2, but its peer range permits it
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Tranquilla
- Stack tecnologico
- typescript
- Ambito
- frontend
Direzione di ricerca
Inizia con la riproduzione in Bun e ispeziona i file runtime SolidFormApi.lib.js, createField.lib.js, AppForm/Components.lib.js e FieldGroup/withFields.lib.js, oltre ai metadati delle dipendenze del package. Confronta la checklist di porting a Solid 2 indicata con le modifiche corrispondenti di solid-store createStoreContext. Il lavoro è completato quando solid-form può essere importato in Solid 2 senza il fallimento dovuto al subpath mancante e il suo intervallo di peer non pubblicizza più versioni non supportate.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Describe the bug
Summary
@tanstack/[email protected] declares peerDependencies: { "solid-js": ">=1.9.5" }.
That range has no upper bound, so it resolves happily against [email protected] —
but the package cannot even be imported under Solid 2.
The sibling Solid packages have already landed Solid 2 builds and bound their ranges:
@tanstack/solid-router 2.0.0-rc.0 solid-js: >=2.0.0-0 <3.0.0
@tanstack/solid-start 2.0.0-rc.0 solid-js: >=2.0.0-0 <3.0.0
@tanstack/solid-query 6.0.0-rc.0 solid-js: >=2.0.0-rc.0 <3.0.0
@tanstack/solid-form 2.0.0-alpha.1 solid-js: >=1.9.5 <-- unbounded
@tanstack/solid-store 0.11.1 solid-js: ^1.6.0
solid-form is the last package blocking an otherwise complete Solid 2 upgrade
for us — router, start and query all work unmodified.
Reproduction
bun add [email protected] @tanstack/[email protected]
echo "import '@tanstack/solid-form'" > probe.ts
bun probe.ts
Result:
error: Cannot find module 'solid-js/web' from
node_modules/@tanstack/solid-store/dist/createStoreContext.js
Solid 2 removed the solid-js/web subpath (the DOM runtime moved to
@solidjs/web), and @tanstack/[email protected] — pulled in as a direct
dependency of solid-form — still imports from it. So the failure is at module
resolution, before any component renders.
On the peer warnings
The install does emit four incorrect peer dependency "[email protected]"
warnings, but none of them come from solid-form itself, whose >=1.9.5 is
satisfied. They come from:
@tanstack/[email protected] peer: ^1.6.0
[email protected] peer: ^1.7.2
[email protected] peer: ^1.9.12
[email protected] peer: ^1.3
So the warnings point at the toolchain rather than at the package that is
actually incompatible, which makes the cause harder to find than it needs to be.
Possibly unintended: vite-plugin-solid is a runtime dependency
"dependencies": {
"@tanstack/solid-store": "^0.11.1",
"vite-plugin-solid": "^2.11.10",
"@tanstack/form-core": "2.0.0-alpha.1"
}
vite-plugin-solid is a build-time plugin, but it sits in dependencies, which
drags babel-preset-solid and solid-refresh into the runtime graph — three of
the four peer warnings above. Moving it to devDependencies (or peerDependencies
if consumers are meant to supply it) would remove that noise independently of
anything Solid 2 related.
Solid 2 port checklist
We have this working through a patches/ override. Every hunk maps to a
documented Solid 1 -> 2 change, so this doubles as a checklist:
@tanstack/solid-store (2 changes, both in createStoreContext):
createComponentimports fromsolid-js, notsolid-js/web- Context objects are the provider:
<Ctx.Provider>->createComponent(Ctx, ...)
@tanstack/solid-form:
3. mergeProps renamed to merge
4. Same Ctx.Provider -> Ctx change in AppForm/Components
5. splitProps replaced by omit in FieldGroup/withFields
6. createRenderEffect is now two-arg (compute, apply); the single-arg form
throws MISSING_EFFECT_FN. Five call sites.
7. createMemo dropped its 3-arg form:
createMemo(fn, undefined, { equals: false }) -> createMemo(fn, { equals: false })
8. Writes from inside an owned scope need the opt-in — createFieldSelector
needs createSignal(initial, { equals, ownedWrite: true })
9. The JSX type moved from solid-js to @solidjs/web (type-only, 5 files)
Runtime files affected: SolidFormApi.lib.js, createField.lib.js,
AppForm/Components.lib.js, FieldGroup/withFields.lib.js.
Questions
- Is Solid 2 support planned for the
solid-formv2 line, or is v2 scoped to
the Form API changes (AppForm,FieldGroup,withFields), with Solid 2
support to follow separately? - Independently of that — would you consider bounding the
solid-jspeer range
on the current alphas? Right now the incompatibility surfaces as a missing
module deep in a transitive dependency rather than at install. - Is
@tanstack/solid-storein scope for a Solid 2 release too? It is the
actual point of failure here, andsolid-formdepends on it directly.
Happy to open a PR for the Solid 2 changes if useful
Environment
solid-js 2.0.0-rc.0
@tanstack/solid-form 2.0.0-alpha.1
@tanstack/solid-store 0.11.1 (direct dependency of solid-form)
@tanstack/solid-router 2.0.0-rc.0 (works unmodified)
@tanstack/solid-query 6.0.0-rc.0 (works unmodified)
@tanstack/solid-start 2.0.0-rc.0 (works unmodified)
bun 1.3.14
Your minimal, reproducible example
Steps to reproduce
Expected behavior
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
TanStack Form adapter
None
TanStack Form version
2.0.0-alpha.1
TypeScript version
No response
Additional context
No response
- Lingua principale
- TypeScript
- Stelle
- 6.8k
- Fork
- 717
- Merge medio
- 5g 22h
- PR unite (30g)
- 14
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TanStack/form
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
Submit listener exceptions leave isSubmitting stuck trueForse già presa @henricop l’ha presa 14 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
handleSubmit calls onSubmit again while a submit is still pending (since 1.33.1)Forse già presa @twotnguyen l’ha presa 14 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
`isDefaultValue` is wrong when a field-level `defaultValue` is `null`Forse già presa @fenet-as l’ha presa 40 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
TanStack/form#2427 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Async validator doesn't re-trigger `isValidating` after first failed validationForse già presa @drewsephski l’ha presa 44 giorni fa. Aperta
Difficoltà 2/5 1-2 giorni Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TanStack/form
Issue simili
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
openclaw/openclaw#203385 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
nwverse/persona#12800 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
I maintainer di solito rispondono entro 1 giorno
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
microsoft/playwright#44289 ·
I maintainer di solito rispondono entro 1 giorno
-
good first issue
Difficoltà 2/5 Mezza giornata Idoneità per principianti 65/100
I maintainer di solito rispondono entro 1 giorno