Production stripping misses plugin factory imports, leaving unused Hotkeys font assets

Aperta Adatta ai principianti
  • Qualcosa non va?
#562 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, typescript, vite
Ambito
devtools, tooling

Direzione di ricerca

Inizia da packages/devtools-bundler-core/src/remove-devtools.ts, in particolare da getPluginReferences, ed esegui la riproduzione autonoma di removeDevtools dell’issue. Controlla come vengono gestite le espressioni di chiamata diretta nell’array plugins e cerca test correlati nel pacchetto bundler-core. Il lavoro è completato quando l’importazione della factory viene rimossa se usata solo all’interno dell’elemento rimosso, ma viene mantenuta se usata altrove.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

TanStack Devtools version
  • @tanstack/react-devtools: 0.10.14
  • @tanstack/devtools-vite: 0.8.6
  • @tanstack/devtools-bundler-core: 0.1.4
  • @tanstack/react-hotkeys-devtools: 0.14.1
  • Transitive @tanstack/devtools-ui: 0.7.2
Framework/Library version

React 19.3.1; TanStack Start 1.169.4; Vite 8.3.5 / Rolldown 1.2.7 through Vite+ 1.4.0; Node.js 26.13.0.

Describe the bug

The production transform removes <TanStackDevtools> but leaves a plugin factory's import when the factory is used directly in the plugins array:

import { TanStackDevtools } from '@tanstack/react-devtools';
import { hotkeysDevtoolsPlugin } from '@tanstack/react-hotkeys-devtools';

export const App = () => (
  <TanStackDevtools plugins={[hotkeysDevtoolsPlugin()]} />
);

hotkeysDevtoolsPlugin is used only inside the removed element, but its import survives. The equivalent inline { name: 'Hotkeys', render: <HotkeysDevtoolsPanel /> } form removes both the element and the plugin import.

This occurs with devtools() first in the Vite plugins array and the default production removal enabled.

Minimal reproduction

The following isolates the stripping bug without a browser, app configuration, or access to the downstream repository. The React imports are source text passed to the parser, so only the bundler-core package needs to be installed.

Run in an empty directory:

npm init -y
npm install --save-exact @tanstack/[email protected]

node --input-type=module <<'NODE'
import { removeDevtools } from '@tanstack/devtools-bundler-core';

const factory = `import { TanStackDevtools } from '@tanstack/react-devtools';
import { hotkeysDevtoolsPlugin } from '@tanstack/react-hotkeys-devtools';
export const App = () => <TanStackDevtools plugins={[hotkeysDevtoolsPlugin()]} />;`;

const panel = `import { TanStackDevtools } from '@tanstack/react-devtools';
import { HotkeysDevtoolsPanel } from '@tanstack/react-hotkeys-devtools';
export const App = () => <TanStackDevtools plugins={[{name: 'Hotkeys', render: <HotkeysDevtoolsPanel/>}]} />;`;

for (const [name, source] of Object.entries({ factory, panel })) {
  console.log(`${name}:\n${removeDevtools(source, 'App.tsx')?.code}`);
}
NODE

Actual output, reproduced against the installed package:

factory:
import { hotkeysDevtoolsPlugin } from '@tanstack/react-hotkeys-devtools';
export const App = () => null;

panel:
export const App = () => null;
Expected behavior

Both examples should produce export const App = () => null;, with no plugin import left behind. A factory import used elsewhere should of course be preserved.

Source investigation

In getPluginReferences, each array element is skipped unless it is an ObjectExpression:

if (!el || el.type !== 'ObjectExpression') continue

A direct hotkeysDevtoolsPlugin() entry is a CallExpression, so its identifier is never collected for the subsequent plugin-import cleanup. The logic handles calls inside an object's render property, but not calls directly inside the plugins array.

Associated production-build impact

Our production client build contains no retained devtools modules, but emits these unreferenced fonts from @tanstack/devtools-ui:

Asset Uncompressed bytes
BricolageGrotesque-Bold-BIJrwikb.BIJrwikb.ttf 82,204
Inter-latin-BwkfbSeq.BwkfbSeq.woff2 72,920
Total 155,124 (151.49 KiB)

Neither filename is referenced by the generated client JS, CSS, HTML, or JSON. This increases emitted-output measurements; it is not evidence of an additional browser download.

The surviving static import appears to expose Vite's related unused-asset retention behavior (vitejs/vite#9073). The transform reproduction above establishes the import-cleanup gap independently of that bundler behavior.

Downstream tracking

Found while investigating mykiary/caniplay.today#293. That repository is private; the standalone reproduction above does not require access.

No upstream fix PR yet.

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Lingua principale
TypeScript
Stelle
510
Fork
103
Merge medio
15h 31m
PR unite (30g)
4

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/devtools

Tutte le issue di TanStack/devtools

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.