electric-db-collection: on-demand + persistence fails after relaunch with "Snapshot requests are not supported in full mode"
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 68/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- react-native, sqlite, typescript
- Ambito
- database
Direzione di ricerca
Start with loadSubset in dist/esm/electric.js around line 248, then trace how needsFullSnapshot selects full mode around line 828. Ask the reporter to share their two-launch node:test reproduction, which exercises electricCollectionOptions, persistedCollectionOptions, and createExpoSQLitePersistence. Done means a relaunch with tagged rows no longer requests a snapshot in full mode and the collection becomes ready.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
In short
An on-demand Electric collection with persistence works on the first app launch, but breaks on every launch after that. The second launch fails with:
Snapshot requests are not supported in full mode
After that error the collection stays in loading, and every live query on it fails until the local data is deleted.
It happens when the shape's rows have tags, which is the case when the shape's where has a subquery.
Versions
@tanstack/electric-db-collection0.5.4. The same code is in 0.5.5 and onmain.@electric-sql/client(the version 0.5.4 depends on)- Persistence:
persistedCollectionOptions+createExpoSQLitePersistence(React Native / Expo)
Setup
electricCollectionOptions({
syncMode: "on-demand",
shapeOptions: {
// the proxy adds a where with a subquery, for example:
// room_id IN (SELECT ... FROM permission_cache WHERE ...)
},
// ...
})
wrapped in persistedCollectionOptions(...).
Steps
- Launch the app. A live query loads a subset. Rows arrive with tags. The library saves a resume state with
requiresTagState: true. - Close the app, then open it again (a new JS process).
What goes wrong, step by step
Line numbers are from dist/esm/electric.js in 0.5.4.
- On the new launch, the tag state from the first launch is gone (it was in memory), so
retainsTagStateisfalse. The saved resume state saysrequiresTagState: true, soneedsFullSnapshotbecomestrue(~line 828). - Because of that, the stream is created in full mode:
logis not'changes_only', and the offset is-1(~line 872). - The live query then calls
loadSubset, andloadSubsetstill callsstream.requestSnapshot(...)(~line 248). - The Electric client does not allow snapshots in full mode, so it throws
Snapshot requests are not supported in full mode. - The throw comes before the stream starts, so the stream never starts and the collection never becomes ready.
So the library chooses full mode, then asks for something that full mode refuses.
Expected
When the stream is in full mode, loadSubset should not request a snapshot. It should wait until the full sync is ready, because the full log will contain the rows anyway.
Our workaround
We ship a small patch (about 35 lines) in loadSubset. When syncMode === 'on-demand' && needsFullSnapshot, it does not call requestSnapshot. It waits for the first markReady instead (it rejects if the initial sync calls markError, and resolves if the collection is aborted).
With the patch, the second launch works. One cost is left: every launch downloads the full shape again, because the tag state is not saved. Saving the tag state with the resume state may be the better fix. You know the design better than we do.
We are glad to open a PR with the patch, or share our test.
Test
We have a node:test test with two "launches". It uses the real electricCollectionOptions + persistedCollectionOptions + createExpoSQLitePersistence over node:sqlite, and a small fake Electric server that tags rows. It fails on 0.5.4 and passes with the patch. We can post it here.
Related
#811 has the same error text, in progressive mode.
- Lingua principale
- TypeScript
- Stelle
- 3.9k
- Fork
- 268
- Merge medio
- 1g 3h
- PR unite (30g)
- 193
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TanStack/db
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
Debounce and throttle paced mutations allow concurrent persistence despite the documented single-flight contractForse già presa @KyleAMathews l’ha presa oggi. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
TanStack/db#1972 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 45/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 45/100
I maintainer di solito rispondono entro 1 giorno
Issue simili
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
Small-tailqwq/dsh-deep-whale#187 ·
I maintainer di solito rispondono entro 1 giorno
-
Tela Marca manda conferir o campo "Razão social", que em Portugal se chama "Denominação social"Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
melgarafael/DeskcommCRM#2503 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
0x80/isolate-package#218 ·
-
bug via-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
pingdotgg/t3code#16859 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 1 giorno