Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

withPersistence stores the durability batch hint on a stopped or failed assistant message

Chiusa
  • Qualcosa non va?
#1,800 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@tombeckenham ci sta già lavorando.

Dal 16/10/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

waiting-on: maintainer
TanStack AI version

@tanstack/ai 0.69.0, @tanstack/ai-persistence 0.9.0 (the same code is on main at 85c2956)

Framework/Library version

Node 26.3.1, server only (no UI framework involved)

Describe the bug and the steps to reproduce it

With snapshotStreaming: true, withPersistence keeps a metadata.tanstack.batch: true key on the stored assistant message when a run is stopped or fails after a middleware called ctx.emitCustomEvent(name, value, { batch: true }).

This is about the message store (stores.messages, which withPersistence writes and reconstructChat reads). It is not about the durability log, the delivery stream that toServerSentEventsResponse({ durability }) appends to. They are separate stores.

The batch hint is an in-process flag for the durability producer. #1355 says it "is stripped before the log and the wire", and stripDurabilityBatchHint does that in toServerSentEventsResponse and in the strip-to-spec middleware. That covers the durability log and the wire. flush() in stream-to-response.ts strips each chunk before durability.append and before forwarding it. The emitted CUSTOM chunk also passes through the middleware chain, though, before any of that. In withPersistence, onChunk merges chunk.metadata of every parent chunk into the streaming snapshot metadata (packages/ai-persistence/src/middleware.ts, the block under "Keep the call metadata (source, response id) for the snapshot rows."). The hint goes in with it. Every later snapshot row carries it. On Stop or on an error, updateStreamingRows(ctx, 'aborted' | 'error') writes the merged metadata to the final stored row, so the hint stays in storage and comes back from reconstructChat. A run that finishes normally is clean, because the final save replaces the snapshot rows.

Steps:

  1. Install @tanstack/[email protected] and @tanstack/[email protected].
  2. Save the script below as repro.mjs in an ESM package and run node repro.mjs.

repro.mjs:

import { chat, defineChatMiddleware } from '@tanstack/ai'
import { memoryPersistence, withPersistence } from '@tanstack/ai-persistence'

const controller = new AbortController()

const adapter = {
  kind: 'text',
  name: 'fixed',
  model: 'test-model',
  '~types': {},
  async *chatStream() {
    const t = Date.now()
    yield { type: 'RUN_STARTED', threadId: 'thread-1', runId: 'run-1', timestamp: t }
    yield { type: 'TEXT_MESSAGE_START', messageId: 'msg-1', role: 'assistant', timestamp: t }
    yield { type: 'TEXT_MESSAGE_CONTENT', messageId: 'msg-1', delta: 'partial', timestamp: t }
    controller.abort() // the user presses Stop
  },
}

const progress = defineChatMiddleware({
  name: 'progress',
  onChunk(ctx, chunk) {
    if (chunk.type === 'TEXT_MESSAGE_CONTENT') {
      ctx.emitCustomEvent('progress', { step: 1 }, { batch: true })
    }
  },
})

const persistence = memoryPersistence()
const stream = chat({
  adapter,
  messages: [{ role: 'user', content: 'hi' }],
  threadId: 'thread-1',
  runId: 'run-1',
  abortController: controller,
  middleware: [
    withPersistence(persistence, { snapshotStreaming: true, snapshotIntervalMs: 0 }),
    progress,
  ],
})
for await (const _ of stream) void _

const stored = await persistence.stores.messages.loadThread('thread-1')
console.log(JSON.stringify(stored.at(-1).metadata))

Expected

{"tanstack":{"source":{"provider":"fixed","api":"text","model":"test-model"},"stopReason":"aborted"}}

Actual

{"tanstack":{"source":{"provider":"fixed","api":"text","model":"test-model"},"batch":true,"stopReason":"aborted"}}

If the adapter throws instead of the abort, the row ends with "batch":true,"stopReason":"error". A snapshot row read in the middle of the run (after a second TEXT_MESSAGE_CONTENT) is {"tanstack":{"source":{...},"batch":true}}.

I found nothing that reads tanstack.batch on a stored message, so the visible effect is a stray internal key in the message store and in the hydrated messages. Any store that validates message metadata will see an unknown key. The hint is meant to stay in process, as the durability log and the wire already show, but the message store keeps it.

Your Minimal, Reproducible Example - (Sandbox Highly Recommended)

Inline above. Plain Node script, no network, no model.

Screenshots or Videos (Optional)

None.

Do you intend to try to help solve this bug with your own PR?

Yes, I am also opening a PR that solves the problem along side this issue

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Lingua principale
TypeScript
Stelle
3.2k
Fork
365
Merge medio
1g 9h
PR unite (30g)
242

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/ai

Tutte le issue di TanStack/ai

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.