Node-path and connection checks resolve scripts by path only, ignoring uid

Aperta
#110 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
76/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
godot, node.js, typescript
Ambito
backend, testing

Direzione di ricerca

Read src/scenes/validate.ts to understand how resolveReference prefers uid over path, then trace scriptViews in src/scenes/node-paths.ts and checkConnections in src/scenes/scene-graph.ts. Run the UID tests in test/uids.test.ts and add coverage for a script resource with a stale path and valid uid. Done means node-path and connection checks still inspect that script; the issue lists npm run build && npm test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

severity: low tech-debt

Summary

#66 unified uid:// resolution for ext_resources, autoloads, the main scene and registry scripts, but the node-path and signal-connection checks still map ext_resource ids to scripts by their path attribute only.

Where

  • src/scenes/node-paths.ts:57-61 (scriptViews)
  • src/scenes/scene-graph.ts:177-182, src/scenes/scene-graph.ts:191-194 (checkConnections)
  • Compare src/scenes/validate.ts:97-127 (resolveReference: uid first, then path)

Impact

When an ext_resource has a stale path but a valid uid (the case scene-ext-resource-path-stale describes), Godot loads the uid's script. The node-path and connection checks silently skip that script, so they miss findings. A third resolution strategy is left to drift.

Suggested fix

Add one per-scene helper, "ext id -> loaded script absolute path", built on resolveReference, and use it in validate.ts, node-paths.ts and scene-graph.ts.

Acceptance criteria

  • A scene whose script ext_resource has a stale path and a valid uid still gets node-path and connection checks.

Getting started

  • Relevant files: src/scenes/node-paths.ts, src/scenes/scene-graph.ts, src/scenes/validate.ts, test/uids.test.ts
  • How to run tests: npm run build && npm test

Related: #66


Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: tech-debt|src/scenes/scene-graph.ts|checkConnections

Lingua principale
TypeScript
Stelle
0
Fork
6
Merge medio
1g 21h
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/godot-correctness-mcp

Tutte le issue di TMHSDigital/godot-correctness-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.