CLI --baseline flattens JSON payloads and resolves paths differently from MCP tools
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
Direzione di ricerca
Start with the baseline handling in src/cli.ts:364-381 and compare it with the MCP handlers in src/tools/scenes.ts and src/tools/lint.ts; then read src/baseline.ts to trace how relative paths are resolved. The proposed parity test belongs in test/tools.test.ts, alongside the existing CLI shape assertion in test/cli.test.ts. Done means every listed command preserves its payload shape, CLI and MCP agree on baseline behavior, the path rule is consistent or documented, and the CHANGELOG records the JSON shape change.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
With --baseline, the CLI replaces every command's JSON payload with a generic {root, findings, count, baselined, staleBaselineEntries}. With a baseline argument, the MCP tools keep each command's own shape. Relative baseline paths also resolve differently: against the cwd in the CLI, and against the project root in MCP. Two hand-written "apply baseline" implementations have already drifted.
Where
src/cli.ts:364-381(generic payload replacement)src/baseline.ts:105-108,src/baseline.ts:133-141(readBaselineuses the cwd;baselineFindingsuses the root)src/tools/scenes.ts:26-30,src/tools/scenes.ts:79-85,src/tools/scenes.ts:97-120;src/tools/lint.ts:62-76test/cli.test.ts:147-155(asserts the flat shape); the parity test attest/tools.test.ts:131runs only without a baseline
Details
if (baseline) {
const r = applyBaseline(root, res.findings, readBaseline(baseline));
res = { root, findings: r.newFindings,
payload: { root, findings: r.newFindings, count: r.newFindings.length,
baselined: r.baselined, staleBaselineEntries: r.stale } };
With a baseline:
gdcorrect reportloses thescenes/project/registries/lintcategories,registryEntriesand the severity counts.lintlosesgodotVersion,fileCountand the counts.validate-registrieslosesentries.
MCP project_report and lint_project keep their shape and recompute the counts. MCP validate_registries keeps entries but has no count.
Impact
Scripts that parse gdcorrect ... --format json break, or read undefined, as soon as a baseline is added. The per-command JSON shapes in the docs only hold without a baseline. One baseline file cannot be referenced with the same relative path from CI and from an agent: game/.gdbaseline.json from the repo root, versus the MCP root-relative game/game/....
Suggested fix
Incremental plan:
- Add a parity test. For each of lint, validate-scenes, validate-project, validate-registries and report, compare CLI
--baselineJSON with the matching MCP tool output givenbaseline. - Add a
severityCounts(findings)helper and replace the five hand-written copies (src/cli.ts,src/lint/project.ts,src/scenes/report.ts,src/tools/lint.ts,src/tools/scenes.ts). - Move the per-command "apply baseline, keep shape, add
baselined/staleBaselineEntries" logic into one shared module, used by bothrunCommandand the tool handlers. - Delete the generic payload in
cli.ts, and addcountto the registries payload. - Choose one resolution rule for relative baseline paths and document it. Root-relative is what MCP already documents.
Acceptance criteria
- CLI and MCP JSON are identical for every command, with and without a baseline.
- The resolution rule for relative baseline paths is the same in both front ends, or the difference is documented in
--helpand README. - CHANGELOG notes the CLI JSON shape change.
Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: bug|src/cli.ts|runCli.baseline-payload
- Lingua principale
- TypeScript
- Stelle
- 0
- Fork
- 6
- Merge medio
- 1g 21h
- PR unite (30g)
- 8
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TMHSDigital/godot-correctness-mcp
-
enhancement good first issue severity: medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
TMHSDigital/godot-correctness-mcp#123 ·
I maintainer di solito rispondono entro 2 giorni
-
dependencies good first issue severity: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
TMHSDigital/godot-correctness-mcp#116 ·
I maintainer di solito rispondono entro 2 giorni
-
bug good first issue severity: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
TMHSDigital/godot-correctness-mcp#107 ·
I maintainer di solito rispondono entro 2 giorni
-
bug good first issue severity: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
TMHSDigital/godot-correctness-mcp#106 ·
I maintainer di solito rispondono entro 2 giorni
-
bug good first issue severity: medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
TMHSDigital/godot-correctness-mcp#105 ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di TMHSDigital/godot-correctness-mcp
Issue simili
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
openclaw/openclaw#203385 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
nwverse/persona#12800 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
I maintainer di solito rispondono entro 1 giorno
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
microsoft/playwright#44289 ·
I maintainer di solito rispondono entro 1 giorno
-
good first issue
Difficoltà 2/5 Mezza giornata Idoneità per principianti 65/100
I maintainer di solito rispondono entro 1 giorno