Replace or slim the unmaintained pyautogui stack and its unused dependencies

Aperta
#154 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
desktop, devtools

Direzione di ricerca

Read autoclicker/core/click_engine.py, autoclicker/core/safety.py, and docs/PERFORMANCE.md to understand current input and safety behavior. The issue proposes lazy importing as a short-term change and replacing the dependency with a Win32 backend or maintained alternative as a longer-term plan. Start with the engine tests and real-input CI job; done means agreeing on the backend plan or replacement and meeting the listed import acceptance criterion.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

dependencies maintenance priority: medium

Summary

pyautogui (latest release 0.9.54) and its helpers (pygetwindow, mouseinfo, pymsgbox, pyrect, pyperclip) see little maintenance, and the app uses only a handful of input and pixel calls. Most of the transitive packages are dead weight in the exe and cost startup time.

Where

  • pyproject.toml:34
  • requirements-lock.txt (pyautogui, pygetwindow, mouseinfo, pymsgbox, pyrect, pyperclip, pyscreeze, pytweening)
  • autoclicker/core/click_engine.py:16 (import pyautogui)
  • autoclicker/core/safety.py

Details

The code already calls Win32 directly through pywin32 and ctypes (core/safety.py, core/screen.py). Importing pyautogui pulls in mouseinfo (which calls SetProcessDPIAware and GetDC(0) at import), pyscreeze and pyrect (which imports doctest). python -X importtime -c "import autoclicker.main" shows import pyautogui taking 0.5 to 1.1 s of a cold start.

Impact

Upstream fixes for new Python versions (CI tests 3.14) are unlikely, the bundled code widens the license surface, and every launch and headless run pays the import cost.

Suggested fix

Short term: exclude unused modules in the spec and import pyautogui lazily inside the click engine so the window appears first. Medium term: replace pyautogui with a thin ctypes SendInput/GetPixel wrapper (the deferred Win32 backend in docs/PERFORMANCE.md), reimplementing FAILSAFE semantics, with the engine tests and the real-input CI job as the safety net.

Acceptance criteria

  • The click engine no longer imports pyautogui at module import
  • Plan agreed for the SendInput backend, or a maintained replacement chosen

Getting started

  • Relevant files: autoclicker/core/click_engine.py, autoclicker/core/safety.py, docs/PERFORMANCE.md
  • How to run tests: make check (Git Bash) or tasks.bat lint, tasks.bat typecheck, tasks.bat test (cmd). Single test: python -m pytest tests/test_x.py::TestClass::test_name --no-cov
  • Related docs: CONTRIBUTING.md, docs/ARCHITECTURE.md

Filed by repo-audit/full-audit at 9968dc8. Severity: medium. Effort: L. audit-key: dependencies|pyproject.toml|pyautogui

Lingua principale
Python
Stelle
0
Fork
2
Merge medio
2g 13h
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/autoclicker

Tutte le issue di TMHSDigital/autoclicker

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.