Neon Golf: add hot-seat stroke play for 2 to 4 players

Aperta
#127 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
56/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
frontend, game-dev

Direzione di ricerca

Read games/golf/scenes/MenuScene.ts, games/golf/scenes/GameScene.ts, and games/golf/scoring.ts, then compare the multiplayer flow in games/tanks/scenes/MenuScene.ts and shared/scenes.ts. Run npm test and review games/golf/scoring.test.ts; done means the menu offers 2 to 4 players, each player's score is summarized, tee order is covered, and a completed round shows a winner.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement help wanted severity: medium

Summary

Neon Golf is solo only. Mini golf is the classic pass-the-device game, and its turn-based shot loop needs no simultaneous input, so it suits hot-seat stroke play for 2 to 4 players.

Where

  • games/golf/scenes/MenuScene.ts:23-28: no modes
  • games/golf/scenes/GameScene.ts:111-118: init() takes no data; one card: number[]
  • games/golf/scoring.ts:63, 83: scorecardLines and summarize work on one player
  • games/tanks/scenes/MenuScene.ts:42-46 and shared/scenes.ts:187 (showMatchResult): the existing pattern for a 2-player mode

Proposal

  • Add menu modes 1 to 4 PLAYERS, with data: { players: n }.
  • Keep a card per player and alternate players on each hole, with each holing out before the next tees off.
  • Color the ball per player, and show one scorecard row per player.
  • End multi-player rounds with showMatchResult, which records a play but skips the solo best, as Tanks does.

Who benefits

Two or more people sharing one phone or tablet. Today they have to play separate full rounds and compare totals.

Open questions

  • Tee order: fixed order, or lowest score so far tees first?
  • Tie-break rule.
  • Related to #113 (alternating whole runs), but golf wants alternation per hole and a shared scorecard.

Acceptance criteria

  • Menu offers 2 to 4 players. The scorecard shows every player and the round ends with a winner.
  • games/golf/scoring.test.ts covers the per-player summary and the tee-order rule.

Getting started

  • Relevant files: games/golf/scenes/*, games/golf/scoring.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at a93de2e. Severity: medium. Effort: M. audit-key: enhancement|games/golf/scenes/GameScene.ts|hot-seat

Lingua principale
TypeScript
Stelle
3
Fork
3
Merge medio
10h 22m
PR unite (30g)
6

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/GH-Arcade

Tutte le issue di TMHSDigital/GH-Arcade

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.