Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

thumbs: the preview licence gate treats a program's software licence as a licence for its website logo or social card, and CC-BY previews carry no creator credit

Chiusa
  • Qualcosa non va?
#132 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, node.js
Ambito
documentation, tooling, web-dev

Direzione di ricerca

Start with site/lib/thumbs.mjs and trace previewEligibility, previewCredit() and checkThumbManifest; inspect the cited records in site/thumbs.json. Then review site/lib/cards.mjs and the Preview images paragraph in CONTRIBUTING.md. Run npm run validate and check that unpinned tools/fonts and CC-BY entries without creator names are flagged, while CC-BY captions show the recorded credit.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug priority: high

Why it matters

Licence correctness is this catalog's whole promise, and the thumbnail pipeline is the one place the repo redistributes third-party bytes. The gate in site/lib/thumbs.mjs (PREVIEW_LICENSES) asks only "is the entry's licence open?", then stores the page's og:image. For tools and fonts that is the wrong question: MIT/GPL/Apache on the program does not license the project's website artwork, logo or social card, and OFL on a font does not license the foundry's marketing image. Separately, CC-BY images are shown without naming the creator, which CC-BY requires.

Evidence (at 69387df)

Tool thumbnails stored under the program's licence (site/thumbs.json, 31 tools records), for example:

id stored licence image actually fetched
blender GPL-2.0-or-later blender.org splash screen (splash art is CC-BY by its artist; the Blender logo is trademarked)
gimp GPL-3.0-or-later Wilber mascot image from gimp.org
audacity, godot-engine, colmap, opentoonz, ldtk, snowb-bmf GPL / MIT / BSD the site's og-image / share-image social card
squoosh Apache-2.0 the app icon (Google branding)
tenacity GPL-2.0-or-later codeberg.org summary card
atkinson-hyperlegible (fonts) SIL OFL Braille Institute social_logo.jpg
jetbrains-mono, inter, orbitron (fonts) SIL OFL foundry preview / marketing images

CONTRIBUTING.md:90 states the assumption explicitly: "CC0, CC-BY, MIT, OFL, GPL and the other open licences that allow a resized copy". SKIP_HOSTS (site/lib/thumbs.mjs:41) only excludes github.com and fonts.google.com.

CC-BY credit: previewCredit() at site/lib/thumbs.mjs:156-159 renders "Preview image from the source page, shown under CC-BY-4.0" when publisher is empty, naming nobody. Six of the thirteen CC-BY thumbnails are in that state (adventure-kid-irs, budgetpixel-sfx, congusbongus-footsteps-surfaces, eric-skiff-resistor-anthems, filmmusic-ende, dareful); five of them already carry an attribution_string that is never used. Cards (site/lib/cards.mjs:33) render the image with alt="" and no credit at all.

Also worth a line in the docs: for itch.io covers (40 of 192 records) the gate assumes the store-page cover art is under the pack's licence, which the pack licence does not say.

Suggested approach

  1. In previewEligibility, restrict automatic og:image fetching to categories where the page image is the asset itself (2d, 3d, characters, animation, audio, shaders-vfx, environment, video), and require an explicit maintainer-checked preview: URL for tools and fonts. Remove the 40 existing tools/fonts records until pinned.
  2. For attribution licences (CC-BY*, CC-BY-SA*), require publisher or attribution_string; otherwise return { ok: false, reason: "attribution licence without a creator name" }. checkThumbManifest then flags the six records.
  3. previewCredit() prefers attribution_string, then publisher. Give card images a title or visible credit for CC-BY.
  4. Rewrite the CONTRIBUTING "Preview images" paragraph to say what the gate actually guarantees, and add the itch cover-art caveat.

Done when

npm run validate fails on a tools/fonts thumbnail without a preview: pin and on a CC-BY thumbnail with no creator name; the entry page caption for a CC-BY image reads the recorded credit line; CONTRIBUTING describes the real rule.

Lingua principale
JavaScript
Stelle
58
Fork
15
Merge medio
16h 53m
PR unite (30g)
14

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/Free-Game-Dev-Assets

Tutte le issue di TMHSDigital/Free-Game-Dev-Assets

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.