Multi-stage cluster addons: Upgrade from faulty cluster stack to one with the same Kubernetes version does not work

Aperta
#212 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
go, kubernetes
Ambito
devops, infrastructure

Direzione di ricerca

The issue names no files or tests. Start by tracing the controller logic for ClusterAddon hooks, cluster stack upgrades, and cluster.spec.topology.class, then inspect existing controller tests if present. Done means a failed stack upgrade clears the old status and spec.hook before the new stack is applied.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Container

What steps did you take and what happened:
Create a cluster stack, e.g. with a wrong CEL expression, so that it will never apply the clusteraddons successfully. Then upgrade to another cluster stack that has no issue. In this case, the AfterControlPlaneInitialized hook will stay in the clusteraddon object and the controller will continue to apply based on AfterControlPlaneInitialized, not BeforeClusterUpgrade.

What did you expect to happen:
The controller should realize that the cluster got upgraded and that it has to remove the existing status and also the spec.hook property.

Currrently, this is not possible, as we cannot know the previous cluster stack if it didn't complete successfully. However, we can solve this by writing the cluster stack that should be upgraded to into the annotations. From there we can read it and if it is set and there is a mismatch between the annotation and the current cluster stack we upgrade to (cluster.spec.topology.class), we know that something went wrong previously and that we should remove the status as well as the spec.hook of clusteraddon.

Lingua principale
Go
Stelle
18
Fork
5
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SovereignCloudStack/cluster-stack-operator

Tutte le issue di SovereignCloudStack/cluster-stack-operator

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.