perf(ci): aggregate per-shard Playwright stats into one workflow-level run

Aperta
#1,171 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github-actions, playwright, typescript
Ambito
ci-cd, testing

Direzione di ricerca

Start by reading packages/stats/scripts/report-playwright.sh and packages/stats/src/routes/playwright-ingest.ts, then inspect the workflow and the sharding change in PR #1170. Compare the report merging options and how uploads create run documents. Done means each workflow run uploads one consolidated result to the stats dashboard while preserving CI pass and fail behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: quality enhancement priority: P3 testing

Context

PR #1170 introduces 4-way Playwright sharding. Each shard currently calls report-playwright.sh with its own partial results.json, which creates 4 separate run documents in the stats dashboard instead of one merged run.

Problem

The stats API (at stats.sonicjs.com) creates a separate run document per upload. With 4 shards + 1 locked job = 5 uploads per workflow run, the dashboard shows 5 partial results (green/red on a subset of tests) rather than one consolidated view.

Options

  1. Merge reports in a final job — add ['blob'] reporter to each shard, download all blob artifacts in a report job, run npx playwright merge-reports, then upload once. Requires a new report job step in the workflow.

  2. Pass --shard metadata to the stats API — modify report-playwright.sh and the stats ingest endpoint to accept a shard identifier and merge partial runs server-side by run_id.

  3. Skip per-shard upload; do one merged upload — simplest from a workflow perspective, but requires implementing option 1 first.

Impact

Non-blocking for CI correctness — tests still pass/fail correctly. Affects only the stats dashboard view quality.

References

  • CodeRabbit comment on PR #1170
  • packages/stats/scripts/report-playwright.sh
  • packages/stats/src/routes/playwright-ingest.ts
Lingua principale
TypeScript
Stelle
1.8k
Fork
219
Merge medio
2g 21h
PR unite (30g)
67

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SonicJs-Org/sonicjs

Tutte le issue di SonicJs-Org/sonicjs

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.