socket fix: remove obsolete overrides and pins it previously wrote

Aperta
  • Qualcosa non va?
#1,688 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
15/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp, java, typescript
Ambito
build-system, cli, security

Direzione di ricerca

This is a design request, not a bug fix. Start by finding the socket fix command entry point in this repository and how it hands changes to the bundled Coana CLI, which is not in the repo. Confirm whether any cleanup of previously written constraints exists. Done means a maintainer-agreed design for ownership tracking, removal criteria and a dry-run report, not a patch.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

socket fix can force a safe version of a transitive dependency by writing an override or equivalent constraint, using each ecosystem's mechanism (see "Supported Ecosystems" in https://docs.socket.dev/docs/socket-fix): for example dependencyManagement in Maven, PackageVersion or PackageReference with NuGet Central Package Management, or overrides/resolutions in JavaScript package managers.

Once a parent dependency is upgraded and the normal graph selects a safe version on its own, the constraint is no longer needed, but it stays in the project and must be found and removed manually. This request is for socket fix to remove the constraints it previously wrote when they are no longer necessary.

Problem

Obsolete pins add noise to manifests and hide the versions the graph would normally select. They can also cause hidden regressions:

  • Maven: a dependencyManagement entry overrides the version chosen through the parent, so after a parent upgrade the build can keep resolving the lower pinned version without warning.
  • NuGet CPM: a stale transitive pin lower than what an upgraded parent requires fails restore with NU1109 (package downgrade detected), and the pin must be found by hand.

JavaScript overrides are opt-in via --allow-overrides, but Maven and NuGet constraints are written as part of the normal fix, so they accumulate with no comparable opt-in.

Current behavior

Socket CLI 1.12.1 has no documented way to find and remove obsolete constraints, and I found no such logic in this repository. Changes are delegated to the bundled Coana CLI 15.13.3, which is not in the repo, so I cannot claim internal cleanup does not exist. Users have no explicit way to request, preview or verify it.

The only alternative is a separate process around socket fix (record each pin, remove it temporarily, re-resolve, rescan, restore if needed), which duplicates work the fix engine already does and is fragile on multi-project solutions.

Requested behavior

An explicit, documented, opt-in capability (for example --prune-overrides) that:

  1. identifies constraints previously written by Socket;
  2. re-resolves without each one, with the project's own tooling;
  3. removes it if no longer necessary, otherwise keeps or restores it;
  4. keeps lockfiles consistent;
  5. reports what was removed, kept, skipped or not evaluable, with a reason (still-required, modified-by-user, resolution-upgraded, could-not-evaluate).

--no-apply-fixes, --json and --output-file could be reused for a dry-run report.

Ownership: only remove constraints Socket can reliably identify as its own, which implies keeping some provenance (a marker comment, a ledger, etc.; the mechanism is up to you). User-managed or user-modified constraints are never touched, at most reported as cleanup candidates.

Removal criteria: remove only if resolution without the constraint succeeds in every affected project or module, the package is gone from the graph or its resolved version is not a downgrade (per the ecosystem's version semantics), and no new known advisory is introduced. A removal that changes the resolved version (for example a stale pin masking a newer parent-selected version) must be reported explicitly, and could sit behind a separate option.

Edge cases: a Directory.Packages.props shared by many projects (related to #1674), a PackageReference added by Socket, and a parent POM dependencyManagement entry inherited by several modules must all be checked across every consumer before removal.

Scope

General socket fix capability, not tied to one package manager. Maven and NuGet CPM are my use cases.

Environment

Written against this version combination:

Component Version
Socket CLI 1.12.1
Coana CLI (bundled) 15.13.3
Lingua principale
TypeScript
Stelle
335
Fork
74
Merge medio
1g 11h
PR unite (30g)
91

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SocketDev/socket-cli

Tutte le issue di SocketDev/socket-cli

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.